From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, robh@kernel.org, marek.behun@nic.cz,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver
Date: Tue, 21 Jul 2020 23:07:24 +0200 [thread overview]
Message-ID: <20200721210724.GD5966@amd> (raw)
In-Reply-To: <20200716182007.18389-4-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
On Thu 2020-07-16 13:19:58, Dan Murphy wrote:
> Introduce the LP5036/30/24/18/12/9 RGB LED driver.
> The difference in these parts are the number of
> LED outputs where the:
>
> LP5036 can control 36 LEDs
> LP5030 can control 30 LEDs
> LP5024 can control 24 LEDs
> LP5018 can control 18 LEDs
> LP5012 can control 12 LEDs
> LP5009 can control 9 LEDs
>
> The device has the ability to group LED output into control banks
> so that multiple LED banks can be controlled with the same mixing and
> brightness. Inversely the LEDs can also be controlled independently.
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> +/*
> + * struct lp50xx_chip_info -
> + * @num_leds: number of LED outputs available on the device
> + * @led_brightness0_reg: first brightness register of the device
> + * @mix_out0_reg: first color mix register of the device
> + * @bank_brt_reg: bank brightness register
> + * @bank_mix_reg: color mix register
> + * @reset_reg: device reset register
> + */
Should have /** if this is kerneldoc.
> + init_data.fwnode = child;
> + num_colors = 0;
> +
> + /* There are only 3 LEDs per module otherwise they should be
> + * banked which also is presented as 3 LEDs
> + */
This is not usual comment style for kernel. (And add . at end of
sentence).
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-07-21 21:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 18:19 [PATCH v31 00/12] Multicolor Framework v31 Dan Murphy
2020-07-16 18:19 ` [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-07-20 9:54 ` Pavel Machek
2020-07-20 12:07 ` Dan Murphy
2020-07-16 18:19 ` [PATCH v31 02/12] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-07-16 18:19 ` [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-07-21 21:05 ` Pavel Machek
2020-07-22 0:04 ` Dan Murphy
2020-07-22 7:10 ` Pavel Machek
2020-07-22 12:26 ` Dan Murphy
2020-07-22 12:39 ` Pavel Machek
2020-07-21 21:07 ` Pavel Machek [this message]
2020-07-22 0:05 ` Dan Murphy
2020-07-16 18:19 ` [PATCH v31 04/12] dt-bindings: leds: Convert leds-lp55xx to yaml Dan Murphy
2020-07-16 18:20 ` [PATCH v31 05/12] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-07-16 18:20 ` [PATCH v31 06/12] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-07-21 21:11 ` Pavel Machek
2020-07-22 16:40 ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 07/12] ARM: defconfig: u8500: Add LP55XX_COMMON config flag Dan Murphy
2020-07-16 18:20 ` [PATCH v31 08/12] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-07-16 18:20 ` [PATCH v31 09/12] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-07-16 18:20 ` [PATCH v31 10/12] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-07-16 18:20 ` [PATCH v31 11/12] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-07-16 18:20 ` [PATCH v31 12/12] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721210724.GD5966@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).