From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Tudor.Ambarus@microchip.com
Cc: alexander.sverdlin@nokia.com, vigneshr@ti.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
ibr@ilbers.de
Subject: Re: [PATCH] mtd: spi-nor: intel-spi: Simulate WRDI command
Date: Wed, 22 Jul 2020 17:36:04 +0300 [thread overview]
Message-ID: <20200722143604.GQ5180@lahna.fi.intel.com> (raw)
In-Reply-To: <b5c17892-24ec-a690-96ca-d2238b8925d1@microchip.com>
Hi,
On Wed, Jul 22, 2020 at 02:28:30PM +0000, Tudor.Ambarus@microchip.com wrote:
> + Mika
>
> Hi, Mika,
>
> Would you please review the patch from below?
Sure, there is minor comment below.
>
> Thanks!
>
> On 7/22/20 5:01 PM, Alexander Sverdlin wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> >
> > After spi_nor_write_disable() return code checks were introduced in the
> > spi-nor front end intel-spi backend stopped to work because WRDI was never
> > supported and always failed.
> >
> > Just pretend it was sucessful and ignore the command itself. HW sequencer
> > shall do the right thing automatically, while with SW sequencer we cannot
> > do it anyway, because the only tool we had was preopcode and it makes no
> > sense for WRDI.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: bce679e5ae3a ("mtd: spi-nor: Check for errors after each Register Operation")
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> > ---
> > drivers/mtd/spi-nor/controllers/intel-spi.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/controllers/intel-spi.c b/drivers/mtd/spi-nor/controllers/intel-spi.c
> > index 61d2a0a..134b356 100644
> > --- a/drivers/mtd/spi-nor/controllers/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/controllers/intel-spi.c
> > @@ -612,6 +612,14 @@ static int intel_spi_write_reg(struct spi_nor *nor, u8 opcode, const u8 *buf,
> > return 0;
> > }
> >
> > + /*
> > + * We hope that HW sequencer will do the right thing automatically and
> > + * with the SW seuencer we cannot use preopcode any way, so just ignore
^^^^^^^^
Typo, should be sequencer.
Otherwise looks good to me.
next prev parent reply other threads:[~2020-07-22 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:01 [PATCH] mtd: spi-nor: intel-spi: Simulate WRDI command Alexander Sverdlin
2020-07-22 14:28 ` Tudor.Ambarus
2020-07-22 14:36 ` Mika Westerberg [this message]
2020-07-22 15:18 ` Tudor.Ambarus
2020-07-22 16:40 ` Alexander Sverdlin
2020-07-23 6:22 ` Mika Westerberg
2020-07-27 12:33 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722143604.GQ5180@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexander.sverdlin@nokia.com \
--cc=ibr@ilbers.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).