From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] XArray for 5.8
Date: Wed, 22 Jul 2020 19:46:36 +0100 [thread overview]
Message-ID: <20200722184636.GQ15516@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=whC-GKFoBGRSnTnD6VxL_J+5xs4BzEhEfyhGMcT8Mga7g@mail.gmail.com>
On Wed, Jul 22, 2020 at 11:40:13AM -0700, Linus Torvalds wrote:
> On Wed, Jul 22, 2020 at 7:11 AM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > XArray updates for 5.8
> >
> > - Fix the test suite after introduction of the local_lock
>
> What? No.
>
> Now you broke the actual kernel build:
>
> In file included from ./include/linux/local_lock.h:5,
> from ./include/linux/radix-tree.h:14,
> from ./include/linux/idr.h:15,
> from lib/idr.c:5:
> ./include/linux/local_lock_internal.h: In function ‘local_lock_acquire’:
> ./include/linux/local_lock_internal.h:41:13: error: ‘current’
> undeclared (first use in this function)
> 41 | l->owner = current;
> | ^~~~~~~
> ./include/linux/local_lock_internal.h:41:13: note: each undeclared
> identifier is reported only once for each function it appears in
>
> How the hell did you not see this, and why did you think it was a good
> idea to mess with kernel headers and make them alphabetically ordered?
Ah, crap. I was building without CONFIG_DEBUG_LOCK_ALLOC, so I didn't
see this.
But I think the real problem is that local_lock_internal.h doesn't include
<linux/sched.h>. Header files shouldn't depend on other headers to be
included first.
> Headers need to be ordered by _contents_, not by some "sort alphabetically".
>
> Do you sort your bookcases by color and size of the book too?
By author, typically ;-)
next prev parent reply other threads:[~2020-07-22 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:11 [GIT PULL] XArray for 5.8 Matthew Wilcox
2020-07-22 18:40 ` Linus Torvalds
2020-07-22 18:46 ` Matthew Wilcox [this message]
2020-07-22 19:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722184636.GQ15516@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).