From: David Miller <davem@davemloft.net>
To: madhuparnabhowmik10@gmail.com
Cc: isdn@linux-pingi.de, arnd@arndb.de, gregkh@linuxfoundation.org,
edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrianov@ispras.ru,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] drivers: isdn: capi: Fix data-race bug
Date: Thu, 23 Jul 2020 15:11:58 -0700 (PDT) [thread overview]
Message-ID: <20200723.151158.2190104866687627036.davem@davemloft.net> (raw)
In-Reply-To: <20200722172329.16727-1-madhuparnabhowmik10@gmail.com>
From: madhuparnabhowmik10@gmail.com
Date: Wed, 22 Jul 2020 22:53:29 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> In capi_init(), after register_chrdev() the file operation callbacks
> can be called. However capinc_tty_init() is called later.
> Since capiminors and capinc_tty_driver are initialized in
> capinc_tty_init(), their initialization can race with their usage
> in various callbacks like in capi_release().
>
> Therefore, call capinc_tty_init() before register_chrdev to avoid
> such race conditions.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
I agree with Arnd that this just exchanges one set of problems for
another.
next prev parent reply other threads:[~2020-07-23 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 17:23 [PATCH] drivers: isdn: capi: Fix data-race bug madhuparnabhowmik10
2020-07-22 18:41 ` Arnd Bergmann
2020-07-23 22:11 ` David Miller [this message]
2020-07-24 4:48 ` Madhuparna Bhowmik
2020-07-24 6:57 ` Greg KH
2020-07-24 14:58 ` Madhuparna Bhowmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723.151158.2190104866687627036.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrianov@ispras.ru \
--cc=arnd@arndb.de \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=isdn@linux-pingi.de \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).