From: Herbert Xu <herbert@gondor.apana.org.au>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] crypto: zip: Convert to DEFINE_SHOW_ATTRIBUTE
Date: Thu, 23 Jul 2020 17:23:52 +1000 [thread overview]
Message-ID: <20200723072352.GA6019@gondor.apana.org.au> (raw)
In-Reply-To: <20200716090354.13454-1-miaoqinglang@huawei.com>
Qinglang Miao <miaoqinglang@huawei.com> wrote:
>
> @@ -584,41 +584,9 @@ static int zip_print_regs(struct seq_file *s, void *unused)
> return 0;
> }
>
> -static int zip_stats_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, zip_show_stats, NULL);
> -}
> -
> -static const struct file_operations zip_stats_fops = {
> - .owner = THIS_MODULE,
> - .open = zip_stats_open,
> - .read_iter = seq_read_iter,
> - .release = single_release,
> -};
This patch doesn't apply either.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-07-23 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 9:03 [PATCH -next] crypto: zip: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
2020-07-23 7:23 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723072352.GA6019@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).