From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Olof Johansson <olof@lixom.net>, arm-soc <arm@kernel.org>,
SoC Team <soc@kernel.org>, Markus Mayer <mmayer@broadcom.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek@lists.infradead.org>,
linux-omap <linux-omap@vger.kernel.org>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 18/23] memory: mtk-smi: Add argument to function definition
Date: Thu, 23 Jul 2020 10:55:33 +0200 [thread overview]
Message-ID: <20200723085533.GA25935@kozik-lap> (raw)
In-Reply-To: <CAK8P3a1TSTX9ATUuyWyqJ1xtd6GP13JM-RQkhGCi1BSTiM9X9A@mail.gmail.com>
On Thu, Jul 23, 2020 at 10:50:08AM +0200, Arnd Bergmann wrote:
> On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > Fix checkpatch warning:
> > WARNING: function definition argument 'struct device *' should also have an identifier name
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Is this a bug in checkpatch? I don't see why it should warn about this,
> as there is no function definition here.
>
> Your change is clearly harmless, but I wonder if we should fix
> checkpatch instead.
Good point. If this were not a warning, I would ignore it. However still
the common practice is to add arguments to such type definitions as it
helps to describe the type.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-07-23 8:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200723073744.13400-1-krzk@kernel.org>
[not found] ` <20200723073744.13400-15-krzk@kernel.org>
2020-07-23 8:48 ` [PATCH 14/23] memory: ti-emif-pm: Fix cast to iomem pointer Arnd Bergmann
2020-07-23 9:02 ` Krzysztof Kozlowski
2020-07-23 9:14 ` Arnd Bergmann
2020-07-23 10:01 ` Krzysztof Kozlowski
[not found] ` <20200723073744.13400-19-krzk@kernel.org>
2020-07-23 8:50 ` [PATCH 18/23] memory: mtk-smi: Add argument to function definition Arnd Bergmann
2020-07-23 8:55 ` Krzysztof Kozlowski [this message]
[not found] ` <20200723073744.13400-20-krzk@kernel.org>
2020-07-23 9:09 ` [PATCH 19/23] memory: omap-gpmc: Enclose macro statements in do-while Arnd Bergmann
2020-07-23 10:16 ` Krzysztof Kozlowski
[not found] ` <20200723073744.13400-21-krzk@kernel.org>
2020-07-23 9:11 ` [PATCH 20/23] memory: omap-gpmc: Fix whitespace issue Arnd Bergmann
2020-07-23 10:08 ` Krzysztof Kozlowski
2020-07-23 9:31 ` [RFC PATCH 00/23] memory: Cleanup, improve and compile test memory drivers Arnd Bergmann
2020-07-23 9:52 ` Krzysztof Kozlowski
2020-07-23 10:14 ` Arnd Bergmann
[not found] ` <20200723073744.13400-17-krzk@kernel.org>
2020-07-23 17:11 ` [PATCH 16/23] memory: brcmstb_dpfe: Constify the contents of string Florian Fainelli
2020-07-23 17:15 ` Markus Mayer
[not found] ` <20200723073744.13400-18-krzk@kernel.org>
2020-07-23 17:11 ` [PATCH 17/23] memory: brcmstb_dpfe: Remove unneeded braces Florian Fainelli
2020-07-23 17:15 ` Markus Mayer
[not found] ` <20200723073744.13400-24-krzk@kernel.org>
2020-07-23 17:12 ` [PATCH 23/23] MAINTAINERS: Add Krzysztof Kozlowski as maintainer of memory controllers Florian Fainelli
2020-07-24 7:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723085533.GA25935@kozik-lap \
--to=krzk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mmayer@broadcom.com \
--cc=olof@lixom.net \
--cc=rogerq@ti.com \
--cc=soc@kernel.org \
--cc=ssantosh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).