From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E00EC433EA for ; Thu, 23 Jul 2020 16:56:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66DAC20771 for ; Thu, 23 Jul 2020 16:56:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="LHhJBmkp"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="XL3SPegn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729959AbgGWQ4a (ORCPT ); Thu, 23 Jul 2020 12:56:30 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:42561 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726621AbgGWQ43 (ORCPT ); Thu, 23 Jul 2020 12:56:29 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 97CED5803E3; Thu, 23 Jul 2020 12:56:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 23 Jul 2020 12:56:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=K g1waUoyA+NkTIudzcDA7EYsIpv+8sxwcxiRVeSkViE=; b=LHhJBmkpXMoLlBGlq jKFJhh+YxPr3fQiICWg55PbLzpTYxX09tFLlPgJYRXfmhXxwJnUlTPzlh4kopqBR Nq96KwXiw3ouV+AuGle3rsTCPe7tUtCJ/wZWYSv2KoHu3V74T93ImaR1NCBI51tw wKpIdtkvpgTDRUgGduKX0JM22IF7XG+IJJ1qeM2Qzt/cI+9U/P1YvW9m8fvzRAv7 l4u/QjCQx/Co1+4Nj8EMrfhKa9o3NKaURwGGOY4dopNEp5mfukJN+QhX7aVLFKsK rBjlcHJq+u/FUjXQPEIQ0RvIeG15ThSP9jjjSWKhoKdxaVaIgY4jX3dLb2Juf0eb auHLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Kg1waUoyA+NkTIudzcDA7EYsIpv+8sxwcxiRVeSkV iE=; b=XL3SPegnwB5spUxfsdsmxNVGfReZ+zHLQ32sFNVZNXlZt+j1K6t6cieEQ otyWGD1Jq7lpcDUIMSuj3yjIJbd195LKLOdLTqxezYOIcdWdriHEpaLCvzDURYUz qzRj9LgFxpDBgAC502d7syXjgWEQEMBTi2odi1pQunqzs5XijqxPW+ruFclsTscI DYuRkc1hxCKfr+P5wS9ZBwEaqpk2xF0UwtK9HZamyh/1wd0ab6Zni9Ro8V0np3IK eSqv8+kh29px2JseVCJ6Q84js81Qyi36IvDmI2n5UCWrcf8KDl+oocPZ81vkRXVs 3Q3cOjfdEC1zPCJzaqHVxGgtbRfag== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrhedugdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedune curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 226EF30600DC; Thu, 23 Jul 2020 12:56:27 -0400 (EDT) Date: Thu, 23 Jul 2020 18:56:25 +0200 From: Maxime Ripard To: Daniel Lezcano Cc: Frank Lee , Frank Lee , Vasily Khoruzhick , Zhang Rui , Amit Kucheria , Chen-Yu Tsai , Linux PM , Linux ARM , Linux Kernel Mailing List , =?utf-8?B?6buE54OB55Sf?= , liyong@allwinnertech.com Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate Message-ID: <20200723165625.zo5d4sv27y3dtcbb@gilmour.lan> References: <4771acd6-ecd3-b8e1-8605-75d78720b1d3@linaro.org> <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 20, 2020 at 12:38:10PM +0200, Daniel Lezcano wrote: > On 20/07/2020 11:27, Frank Lee wrote: > > HI, > > On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano > > wrote: > >> > >> On 17/07/2020 09:35, Frank Lee wrote: > >>> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano > >>> wrote: > >>>> > >>>> On 14/07/2020 09:13, Frank Lee wrote: > >>>>> From: Yangtao Li > >>>>> > >>>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a rou= nd of > >>>>> calculation. On the other hand, the newer SOC may store other data = in > >>>>> the space other than 12bit sensor data. Add mask operation to read = data > >>>>> to avoid conversion error. > >>>>> > >>>>> Signed-off-by: Yangtao Li > >>>>> Reviewed-by: Yangtao Li > >>>> > >>>> Can you clarify these SoB ? > >>> > >>> Previously I used 'Signed-off-by: Yangtao Li ', > >>> maybe this should be removed directly? > >>> > >>>> > >>>> Frank Lee=3D=3DYangtao Li=3D=3Dfrank@allwinnertech.com=3D=3Dtiny.win= dzz@gmail.com ? > >>>> > >>> > >>> Yeah. > >> > >> You are not supposed to add reviewed-by yourself. Please remove it. > >=20 > > Should I resend the entire series or just the thermal patch? > > What about those that have been applied. >=20 > I can not speak on behalf of other maintainers. >=20 > The simplest would be to ask them directly. >=20 > If you want to go forward with the thermal changes, you can send them > separately but Maxim's Ack will be needed anyway. Given that I had a few other comments on the other patches, I guess you can resend the whole series, it will be simpler to track down. Maxime