From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: herbert@gondor.apana.org.au, cohuck@redhat.com,
nhorman@redhat.com, vdronov@redhat.com, bhelgaas@google.com,
mark.a.chambers@intel.com, gordon.mcfadden@intel.com,
ahsan.atta@intel.com, qat-linux@intel.com, kvm@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] vfio/pci: Add device blocklist
Date: Thu, 23 Jul 2020 22:40:29 +0100 [thread overview]
Message-ID: <20200723214029.GA6572@silpixa00400314> (raw)
In-Reply-To: <20200722230210.55b2d326@x1.home>
On Wed, Jul 22, 2020 at 11:02:10PM -0600, Alex Williamson wrote:
> On Tue, 14 Jul 2020 07:36:07 +0100
> Giovanni Cabiddu <giovanni.cabiddu@intel.com> wrote:
>
> > Add blocklist of devices that by default are not probed by vfio-pci.
> > Devices in this list may be susceptible to untrusted application, even
> > if the IOMMU is enabled. To be accessed via vfio-pci, the user has to
> > explicitly disable the blocklist.
> >
> > The blocklist can be disabled via the module parameter disable_blocklist.
> >
> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> > ---
> > drivers/vfio/pci/vfio_pci.c | 33 +++++++++++++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
>
> Hi Giovanni,
>
> I'm pretty satisfied with this series, except "blocklist" makes me
> think of block devices, ie. storage, or block chains, or building block
> types of things before I get to "block" as in a barrier. The other
> alternative listed as a suggestion currently in linux-next is denylist,
> which is the counter to an allowlist. I've already proposed changing
> some other terminology in vfio.c to use the term "allowed", so
> allow/deny would be my preference versus pass/block.
Thanks Alex for your feedback. A new revision is on the way.
Regards,
--
Giovanni
next prev parent reply other threads:[~2020-07-23 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 6:36 [PATCH v2 0/5] vfio/pci: add blocklist and disable qat Giovanni Cabiddu
2020-07-14 6:36 ` [PATCH v2 1/5] PCI: Add Intel QuickAssist device IDs Giovanni Cabiddu
2020-07-14 15:28 ` Bjorn Helgaas
2020-07-14 6:36 ` [PATCH v2 2/5] vfio/pci: Add device blocklist Giovanni Cabiddu
2020-07-23 5:02 ` Alex Williamson
2020-07-23 21:40 ` Giovanni Cabiddu [this message]
2020-07-14 6:36 ` [PATCH v2 3/5] vfio/pci: Add QAT devices to blocklist Giovanni Cabiddu
2020-07-14 6:36 ` [PATCH v2 4/5] crypto: qat - replace device ids defines Giovanni Cabiddu
2020-07-14 6:36 ` [PATCH v2 5/5] crypto: qat - use PCI_VDEVICE Giovanni Cabiddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723214029.GA6572@silpixa00400314 \
--to=giovanni.cabiddu@intel.com \
--cc=ahsan.atta@intel.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=gordon.mcfadden@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.a.chambers@intel.com \
--cc=nhorman@redhat.com \
--cc=qat-linux@intel.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).