From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D81C433E3 for ; Fri, 24 Jul 2020 03:34:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3B4B20714 for ; Fri, 24 Jul 2020 03:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726781AbgGXDd7 (ORCPT ); Thu, 23 Jul 2020 23:33:59 -0400 Received: from mga09.intel.com ([134.134.136.24]:54062 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbgGXDd7 (ORCPT ); Thu, 23 Jul 2020 23:33:59 -0400 IronPort-SDR: kAffvOSvlCd4Wu/42QmN1hogMcU6tMw2S8ekM9zAX89pP0JT9ncTgK18ZoJQS7w3bxMZXGaQEm hBfqs3q+FcLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="151946619" X-IronPort-AV: E=Sophos;i="5.75,389,1589266800"; d="scan'208";a="151946619" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 20:33:59 -0700 IronPort-SDR: tsIiMTQxqZopYL4E5PSJxhnxVaVsDCHS4RSi5PAM0bUBmPj6Th2qsXxUg/T3z5puyRfx2b76e6 RosXaunVAAcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,389,1589266800"; d="scan'208";a="463086811" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.141]) by orsmga005.jf.intel.com with ESMTP; 23 Jul 2020 20:33:57 -0700 Date: Fri, 24 Jul 2020 11:30:45 +0800 From: Xu Yilun To: Randy Dunlap Cc: mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com, lgoncalv@redhat.com Subject: Re: [PATCH v2 0/4] Modularization of DFL private feature drivers Message-ID: <20200724033045.GA5726@yilunxu-OptiPlex-7050> References: <1595556555-9903-1-git-send-email-yilun.xu@intel.com> <7ff4653b-dcf0-e7d4-9d09-a30a9f857661@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ff4653b-dcf0-e7d4-9d09-a30a9f857661@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 23, 2020 at 08:03:52PM -0700, Randy Dunlap wrote: > On 7/23/20 7:09 PM, Xu Yilun wrote: > > This patchset makes it possible to develop independent driver modules > > for DFL private features. It also helps to leverage existing kernel > > drivers to enable some IP blocks in DFL. > > > > Patch #1: An improvement of feature id definition. The feature id will be used > > as the key field for dfl device/driver matching. > > Patch #2: Release the dfl mmio regions after enumeration, so that private > > feature drivers could request mmio region in their own drivers. > > Patch #3: Introduce the dfl bus, then dfl devices could be supported by > > independent dfl drivers. > > Patch #4: An example of the dfl driver for N3000 nios private feature. > > > > Hi, > What is "nios"? Is that explained or described anywhere? It is the NIOS2 soft processor mostly used in the FPGA. I see the there is an arch/nios2 folder in kernel. On Intel PAC N3000 card, the embedded NIOS2 core in FPGA does some Board initialization work (Mostly the configuration of ethernet retimer) on reboot. And the dfl-n3000-nios private feature in DFL is actually the handshake interfaces for host to communicate with the NIOS2 core, about what parameters to use, when the configuration is finished ... Thanks, Yilun > > > > > Main changes from v1: > > - Add the new Patch #1, to improve the feature id definition. > > - Change the dfl bus uevent format. > > - Change the dfl device's sysfs name format. > > - refactor dfl_dev_add() > > - Add the Patch #4 as an example of the dfl driver. > > - A lot of minor fixes for comments from Hao and Tom. > > thanks. > -- > ~Randy