From: Andrea Righi <andrea.righi@canonical.com>
To: David Miller <davem@davemloft.net>
Cc: boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, kuba@kernel.org,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen-netfront: fix potential deadlock in xennet_remove()
Date: Fri, 24 Jul 2020 08:30:52 +0200 [thread overview]
Message-ID: <20200724063052.GG841369@xps-13> (raw)
In-Reply-To: <20200723.145722.752878326752101646.davem@davemloft.net>
On Thu, Jul 23, 2020 at 02:57:22PM -0700, David Miller wrote:
> From: Andrea Righi <andrea.righi@canonical.com>
> Date: Wed, 22 Jul 2020 08:52:11 +0200
>
> > +static int xennet_remove(struct xenbus_device *dev)
> > +{
> > + struct netfront_info *info = dev_get_drvdata(&dev->dev);
> > +
> > + dev_dbg(&dev->dev, "%s\n", dev->nodename);
>
> These kinds of debugging messages provide zero context and are so much
> less useful than simply using tracepoints which are more universally
> available than printk debugging facilities.
>
> Please remove all of the dev_dbg() calls from this patch.
I didn't add that dev_dbg() call, it's just the old code moved around,
but I agree, I'll remove that call and send a new version of this patch.
Thanks for looking at it!
-Andrea
prev parent reply other threads:[~2020-07-24 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 6:52 [PATCH] xen-netfront: fix potential deadlock in xennet_remove() Andrea Righi
2020-07-23 21:57 ` David Miller
2020-07-24 6:30 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724063052.GG841369@xps-13 \
--to=andrea.righi@canonical.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=jgross@suse.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).