From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01506C433E3 for ; Fri, 24 Jul 2020 19:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7B39206D8 for ; Fri, 24 Jul 2020 19:04:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YJdzU2vs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbgGXTEl (ORCPT ); Fri, 24 Jul 2020 15:04:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgGXTEk (ORCPT ); Fri, 24 Jul 2020 15:04:40 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37E05C0619E4 for ; Fri, 24 Jul 2020 12:04:40 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id k27so5844385pgm.2 for ; Fri, 24 Jul 2020 12:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LrMXrDf7YIZaoWeBKOjSOSMpqfT8SAqX0JXj+wrASIM=; b=YJdzU2vsfQm7AZSEbQDHOGAXkb0FDmlYvGdDHcCBV0Mb+I/0YGXEnNHZP0ITEGdZnq rMUzebIoCugRClDH5RJXQ2VNELpwlavB8ApMKzNJeTwVnKrJanhG9XCaDVo5IwEReNVE 3/qzt3XofNbnyZe3522KpHnb11vBLC4noGHZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LrMXrDf7YIZaoWeBKOjSOSMpqfT8SAqX0JXj+wrASIM=; b=dpjCRGtWmU/FUApKh1rIdKL7Ss6MMkKi+x2QnqVin4Z6ugOGQl1E268ShHoM1eJYbA cjy4fvPTeeMHIWJ8VYee2aRXBfaHiQF3vzpVnAcwcpj5DG+v3s44zMmD1er0N1xRlenf U6Ibcr3SSETJu9IZFSBCjepbeG4yfQBcC4r9aVRcm3N5qReXQn1IOKBAzm5/GVWQSMa0 0ZqLxg2FF8SGgmHKA3NNDaIke+yk6EnwHQ3RR25p0KtVPddvVOkIP+iScpcfa9tgNAjK CLVNUh1YvNd1ZEEOKSDoI2TcNKZ35caujlB8/Z1qmesPOIZSvRFlJvxPoM0/XrAo4Mee 4kAQ== X-Gm-Message-State: AOAM532lV31oge0VBQ5MGQVdyVraZO3QZ7lYoBI/Y3XE4VhTWJz6xRcW chwKw+QLhqL2KGtuMWwEX6vAag== X-Google-Smtp-Source: ABdhPJwByOH/4ROCOy3QCc3kWU3xI1XY75NRzmOAdHNrzalnVxff+4jx3AjnVMN92eX9iE8obAmE4g== X-Received: by 2002:a62:5297:: with SMTP id g145mr10327624pfb.28.1595617479754; Fri, 24 Jul 2020 12:04:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y7sm6228743pjp.47.2020.07.24.12.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 12:04:38 -0700 (PDT) Date: Fri, 24 Jul 2020 12:04:38 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Aleksa Sarai , Alexei Starovoitov , Al Viro , Andrew Morton , Andy Lutomirski , Christian Brauner , Christian Heimes , Daniel Borkmann , Deven Bowers , Dmitry Vyukov , Eric Biggers , Eric Chiang , Florian Weimer , James Morris , Jan Kara , Jann Horn , Jonathan Corbet , Lakshmi Ramasubramanian , Matthew Garrett , Matthew Wilcox , Michael Kerrisk , Mimi Zohar , Philippe =?iso-8859-1?Q?Tr=E9buchet?= , Scott Shell , Sean Christopherson , Shuah Khan , Steve Dower , Steve Grubb , Tetsuo Handa , Thibaut Sautereau , Vincent Strubel , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v7 7/7] ima: add policy support for the new file open MAY_OPENEXEC flag Message-ID: <202007241204.3DD9B905E@keescook> References: <20200723171227.446711-1-mic@digikod.net> <20200723171227.446711-8-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200723171227.446711-8-mic@digikod.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 23, 2020 at 07:12:27PM +0200, Mickaël Salaün wrote: > From: Mimi Zohar > > The kernel has no way of differentiating between a file containing data > or code being opened by an interpreter. The proposed O_MAYEXEC > openat2(2) flag bridges this gap by defining and enabling the > MAY_OPENEXEC flag. > > This patch adds IMA policy support for the new MAY_OPENEXEC flag. > > Example: > measure func=FILE_CHECK mask=^MAY_OPENEXEC > appraise func=FILE_CHECK appraise_type=imasig mask=^MAY_OPENEXEC > > Signed-off-by: Mickaël Salaün ^^^ this S-o-b should the last in the fields. > Signed-off-by: Mimi Zohar > Reviewed-by: Lakshmi Ramasubramanian > Link: https://lore.kernel.org/r/1588167523-7866-3-git-send-email-zohar@linux.ibm.com Reviewed-by: Kees Cook -- Kees Cook