From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jessica Yu <jeyu@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex
Date: Sat, 25 Jul 2020 05:42:27 +0300 [thread overview]
Message-ID: <20200725024227.GD17052@linux.intel.com> (raw)
In-Reply-To: <20200724102258.GB2831654@kernel.org>
On Fri, Jul 24, 2020 at 01:22:58PM +0300, Mike Rapoport wrote:
> On Fri, Jul 24, 2020 at 08:05:48AM +0300, Jarkko Sakkinen wrote:
> > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex
> > in order to remove the compile time dependency to it.
> >
> > Cc: linux-mm@kvack.org
> > Cc: Andi Kleen <ak@linux.intel.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Suggested-by: Masami Hiramatsu <mhiramat@kernel.org>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > ---
> > include/linux/module.h | 18 ++++++++++++++++++
> > kernel/kprobes.c | 4 ++--
> > kernel/trace/trace_kprobe.c | 4 ++--
> > 3 files changed, 22 insertions(+), 4 deletions(-)
>
> Any reason to convert only kprobes to the new API and leave others with
> opencoded implementation?
Not anything particular.
Lets see:
$ git --no-pager grep "mutex_lock(&module_mutex)"
arch/powerpc/platforms/powernv/pci-cxl.c: mutex_lock(&module_mutex);
drivers/gpu/drm/drm_fb_helper.c: mutex_lock(&module_mutex);
include/linux/module.h: mutex_lock(&module_mutex);
kernel/livepatch/core.c: mutex_lock(&module_mutex);
kernel/livepatch/core.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
kernel/module.c: mutex_lock(&module_mutex);
I could refine this commit to patch these sites. Or should I split it
into multiple?
/Jarkko
next prev parent reply other threads:[~2020-07-25 2:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 5:05 [PATCH v5 0/6] arch/x86: kprobes: Remove MODULES dependency Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex Jarkko Sakkinen
2020-07-24 9:13 ` Ingo Molnar
2020-07-25 2:36 ` Jarkko Sakkinen
2020-07-24 9:17 ` Ingo Molnar
2020-07-25 3:01 ` Jarkko Sakkinen
2020-07-25 10:21 ` Ingo Molnar
2020-07-28 7:34 ` Masami Hiramatsu
2020-07-28 12:29 ` [tip: perf/core] kprobes: Remove unnecessary module_mutex locking from kprobe_optimizer() tip-bot2 for Masami Hiramatsu
2020-08-17 21:22 ` [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex Jarkko Sakkinen
2020-07-24 10:22 ` Mike Rapoport
2020-07-25 2:42 ` Jarkko Sakkinen [this message]
2020-07-24 14:46 ` Masami Hiramatsu
2020-07-25 2:48 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 2/6] vmalloc: Add text_alloc() and text_free() Jarkko Sakkinen
2020-07-24 10:22 ` Mike Rapoport
2020-07-25 2:20 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 3/6] arch/x86: Implement " Jarkko Sakkinen
2020-07-24 9:22 ` Ingo Molnar
2020-07-25 2:03 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 4/6] arch/x86: kprobes: Use " Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 5/6] " Jarkko Sakkinen
2020-07-24 9:27 ` Ingo Molnar
2020-07-24 12:16 ` Ard Biesheuvel
2020-07-25 3:19 ` [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()] Jarkko Sakkinen
2020-07-25 3:16 ` [PATCH v5 5/6] kprobes: Use text_alloc() and text_free() Jarkko Sakkinen
2020-07-26 8:14 ` Mike Rapoport
2020-07-26 16:06 ` Ard Biesheuvel
2020-07-28 8:17 ` Masami Hiramatsu
2020-07-28 10:56 ` Ard Biesheuvel
2020-07-28 13:35 ` Masami Hiramatsu
2020-07-28 17:51 ` Ard Biesheuvel
2020-07-29 1:50 ` Masami Hiramatsu
2020-07-29 6:13 ` Ard Biesheuvel
2020-07-30 1:09 ` Masami Hiramatsu
2020-08-18 5:30 ` Jarkko Sakkinen
2020-08-18 11:51 ` Mike Rapoport
2020-08-18 16:30 ` Jarkko Sakkinen
2020-08-19 6:47 ` Mike Rapoport
2020-08-19 21:07 ` Jarkko Sakkinen
2020-07-24 10:27 ` Mike Rapoport
2020-07-24 14:57 ` Masami Hiramatsu
2020-07-24 23:38 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 6/6] kprobes: Remove CONFIG_MODULES dependency Jarkko Sakkinen
2020-07-24 7:01 ` [PATCH v5 0/6] arch/x86: kprobes: Remove MODULES dependency Jarkko Sakkinen
2020-07-24 10:26 ` Mike Rapoport
-- strict thread matches above, loose matches on Subject: below --
2020-07-24 5:04 Jarkko Sakkinen
2020-07-24 5:04 ` [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200725024227.GD17052@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).