From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76A0C433E0 for ; Sun, 26 Jul 2020 12:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8761D20714 for ; Sun, 26 Jul 2020 12:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595766373; bh=fCDE7fxJVUavVe9TqBxIOmulaM5drOP0NXsSYMv3oi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2kvskqR+jmbtiUOhO21afgi/1Xy+pGSvVJWVj8KGgujLWFHPNT/Q1Pb4cd2qq8lNE Ua7jA8cXy1j1QUQr0xf7YFCiFwG3uxfdj+HvPODejm5+FHvGopMZb7AmoXPwNId1po 2JC7TF0Jh8ff4p06XS/EtzuDpet6Q0fplMioi14g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbgGZM0M (ORCPT ); Sun, 26 Jul 2020 08:26:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:54746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbgGZM0L (ORCPT ); Sun, 26 Jul 2020 08:26:11 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC85F206D8; Sun, 26 Jul 2020 12:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595766371; bh=fCDE7fxJVUavVe9TqBxIOmulaM5drOP0NXsSYMv3oi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aM5rxlB0Jx7/3CB0uzqmU0b/o0Yu4nSluZv6s3JgeLvS+jvVMyKXbqrcBDZ14odZO EIt9Bm1plvCTlTSAuonHY4lvRm4pu0CGRZBOhuX9P6rWZHkvT93QiGVf8Lv9WVzl9Y Suuu/SkSbp6P91ZLm36iksMT1nGt6V+jiQf2Pv8A= Date: Sun, 26 Jul 2020 13:26:07 +0100 From: Jonathan Cameron To: Guenter Roeck Cc: Enric Balletbo i Serra , Benson Leung , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Yu-Hsuan Hsu , Prashant Malani Subject: Re: [PATCH v2 1/4] iio: cros_ec: Accept -EOPNOTSUPP as 'not supported' error code Message-ID: <20200726132607.5e260674@archlinux> In-Reply-To: <20200720202243.180230-2-linux@roeck-us.net> References: <20200720202243.180230-1-linux@roeck-us.net> <20200720202243.180230-2-linux@roeck-us.net> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jul 2020 13:22:40 -0700 Guenter Roeck wrote: > A follow-up patch will extend the number of errors reported by > cros_ec_cmd_xfer_status(). Specifically, the function will return > -EOPNOTSUPP if a command is not supported by the EC. Prepare for it. > > Cc: Yu-Hsuan Hsu > Cc: Prashant Malani > Signed-off-by: Guenter Roeck Acked-by: Jonathan Cameron > --- > v2: Added patch > > drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > index a66941fdb385..e3aff95493dd 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > @@ -73,7 +73,7 @@ static int cros_ec_sensors_read(struct iio_dev *indio_dev, > st->core.param.sensor_offset.flags = 0; > > ret = cros_ec_motion_send_host_cmd(&st->core, 0); > - if (ret == -EPROTO) { > + if (ret == -EPROTO || ret == -EOPNOTSUPP) { > /* Reading calibscale is not supported on older EC. */ > *val = 1; > *val2 = 0;