linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE
Date: Mon, 27 Jul 2020 00:09:49 +0200	[thread overview]
Message-ID: <20200726220949.m456hoqcb5bis4ry@earth.universe> (raw)
In-Reply-To: <20200716085849.11571-1-miaoqinglang@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

Hi,

On Thu, Jul 16, 2020 at 04:58:49PM +0800, Qinglang Miao wrote:
> From: Yongqiang Liu <liuyongqiang13@huawei.com>
> 
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>

Thanks, queued.

-- Sebastian

>  drivers/power/supply/da9030_battery.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/power/supply/da9030_battery.c b/drivers/power/supply/da9030_battery.c
> index 292ecf875..0deba48d2 100644
> --- a/drivers/power/supply/da9030_battery.c
> +++ b/drivers/power/supply/da9030_battery.c
> @@ -172,17 +172,7 @@ static int bat_debug_show(struct seq_file *s, void *data)
>  	return 0;
>  }
>  
> -static int debug_open(struct inode *inode, struct file *file)
> -{
> -	return single_open(file, bat_debug_show, inode->i_private);
> -}
> -
> -static const struct file_operations bat_debug_fops = {
> -	.open		= debug_open,
> -	.read_iter		= seq_read_iter,
> -	.llseek		= seq_lseek,
> -	.release	= single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(bat_debug);
>  
>  static struct dentry *da9030_bat_create_debugfs(struct da9030_charger *charger)
>  {
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-07-26 22:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16  8:58 [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
2020-07-26 22:09 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200726220949.m456hoqcb5bis4ry@earth.universe \
    --to=sre@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=miaoqinglang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).