From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C635C433E0 for ; Mon, 27 Jul 2020 04:46:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EC252073E for ; Mon, 27 Jul 2020 04:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595825191; bh=FaoNP8k6aSLsx7TpTwjKJPpQYLPjHTrsR+RxlYSUviU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vO7BuDqCnFIp7sgs8cZzIC4vllAeiNjKPXHuptvaufT7zN7+k4wp0Kni6pMO+j7Au 0ChQO4ltdLAhUwNLWIc4rK9VGZxhEaK1XvGWqn9MUQbCAwjMaLBH8XNFeVXPuPyqui bTUamp6lFQl+7GsQsSUZ6BmKTzC+gAm8WLCS/hCk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726247AbgG0Eq2 (ORCPT ); Mon, 27 Jul 2020 00:46:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:46244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbgG0Eq2 (ORCPT ); Mon, 27 Jul 2020 00:46:28 -0400 Received: from Mani-XPS-13-9360 (unknown [157.46.48.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 957FB2073E; Mon, 27 Jul 2020 04:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595825187; bh=FaoNP8k6aSLsx7TpTwjKJPpQYLPjHTrsR+RxlYSUviU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DxKMTyFAiQtwVJ8+TAzrsFrS/urT4BTzQAYkttN0vO2lb6v9eml9DXxa+OimH6s4P ZrQmPSpmfk5J+mmY+BuhCpQSKoJ7Ponb9EW7asDNx4P3w5Q8K2LnLQjP7pk1qDF5s6 6YSFkrGND2zQeHtOwkqIU6ZB7lPxzIM0qddlynjM= Date: Mon, 27 Jul 2020 10:16:10 +0530 From: Manivannan Sadhasivam To: Andy Shevchenko Cc: Johan Hovold , Greg Kroah-Hartman , USB , Linux Kernel Mailing List , patong.mxl@gmail.com, Linus Walleij , Mauro Carvalho Chehab , "open list:GPIO SUBSYSTEM" Subject: Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support Message-ID: <20200727044610.GC12036@Mani-XPS-13-9360> References: <20200607162350.21297-1-mani@kernel.org> <20200607162350.21297-3-mani@kernel.org> <20200701130206.GD3334@localhost> <20200726155223.GB12036@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 26, 2020 at 07:34:54PM +0300, Andy Shevchenko wrote: > On Sun, Jul 26, 2020 at 6:53 PM Manivannan Sadhasivam wrote: > > On Wed, Jul 01, 2020 at 03:02:06PM +0200, Johan Hovold wrote: > > > On Sun, Jun 07, 2020 at 09:53:49PM +0530, Manivannan Sadhasivam wrote: > > ... > > > > Same here. And perhaps just ignoring the pins managed by gpiolib is > > > better (cf. gpiolib and pinctrl being orthogonal). > > > > You mean, we can just make TX,RX,CTS,RTS pins controlled only by the serial > > driver and the rest only by gpiolib? > > I'm wondering if you may use mctrl_gpio_*() API instead. How? mctrl_gpio APIs are a wrapper for accessing modem control gpio pins but here we are not accessing the pins but rather exposing the pins as a gpiochip. Am I missing something? Thanks, Mani > > -- > With Best Regards, > Andy Shevchenko