linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	David Miller <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alain Michaud <alainm@chromium.org>,
	Christoph Hellwig <hch@lst.de>
Subject: linux-next: build failure after merge of the bluetooth tree
Date: Mon, 27 Jul 2020 13:44:33 +1000	[thread overview]
Message-ID: <20200727134433.1c4ea34e@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

Hi all,

After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/bluetooth/sco.c: In function 'sco_sock_setsockopt':
net/bluetooth/sco.c:862:3: error: cannot convert to a pointer type
  862 |   if (get_user(opt, (u32 __user *)optval)) {
      |   ^~
net/bluetooth/sco.c:862:3: error: cannot convert to a pointer type
net/bluetooth/sco.c:862:3: error: cannot convert to a pointer type

Caused by commit

  00398e1d5183 ("Bluetooth: Add support for BT_PKT_STATUS CMSG data for SCO connections")

interacting with commit

  a7b75c5a8c41 ("net: pass a sockptr_t into ->setsockopt")

from the net-next tree.

I have applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 27 Jul 2020 13:41:30 +1000
Subject: [PATCH] Bluetooth: fix for introduction of sockptr_t

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/bluetooth/sco.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index 6e6b03844a2a..dcf7f96ff417 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -859,7 +859,7 @@ static int sco_sock_setsockopt(struct socket *sock, int level, int optname,
 		break;
 
 	case BT_PKT_STATUS:
-		if (get_user(opt, (u32 __user *)optval)) {
+		if (copy_from_sockptr(&opt, optval, sizeof(u32))) {
 			err = -EFAULT;
 			break;
 		}
-- 
2.27.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2020-07-27  3:45 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  3:44 Stephen Rothwell [this message]
2020-07-27  5:22 ` linux-next: build failure after merge of the bluetooth tree Christoph Hellwig
2020-07-27 13:28   ` Alain Michaud
  -- strict thread matches above, loose matches on Subject: below --
2024-05-01  1:19 Stephen Rothwell
2024-05-01  1:34 ` Sungwoo Kim
2023-07-20 22:21 Iwashima, Kuniyuki
     [not found] <PH0PR11MB51269B6805230AB8ED209B14D332A@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-07-20  0:50 ` Stephen Rothwell
2023-07-20  1:24   ` Jakub Kicinski
2023-07-20  3:00     ` Stephen Rothwell
     [not found]       ` <PH0PR11MB5126763E5913574B8ED6BDE4D33EA@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-07-20  3:24         ` Jakub Kicinski
2023-07-20  6:00           ` Alexander Mikhalitsyn
2023-07-20 15:14           ` Jakub Kicinski
2023-07-20 15:21             ` Alexander Mikhalitsyn
2023-07-20 22:19               ` Stephen Rothwell
2023-07-20 22:12             ` Stephen Rothwell
2023-07-20 23:27               ` Jakub Kicinski
2023-07-20 23:30                 ` Stephen Rothwell
     [not found] <PH0PR11MB51262F07CD4739BDCB920483D322A@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-06-23  8:34 ` Alexander Mikhalitsyn
2023-06-23  9:23   ` Alexander Mikhalitsyn
2023-06-23 12:24     ` Christian Brauner
2023-06-23 12:28       ` Alexander Mikhalitsyn
2023-06-23 15:09         ` Jakub Kicinski
2023-06-26 22:09           ` Alexander Mikhalitsyn
     [not found] <PH0PR11MB5126F2B2E020774AF8D91299D35BA@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-06-15 23:27 ` Stephen Rothwell
2023-06-13  3:02 Stephen Rothwell
2023-06-15 22:32 ` Stephen Rothwell
2023-07-06 23:41   ` Stephen Rothwell
2021-12-07  0:26 Stephen Rothwell
2021-12-06  0:37 Stephen Rothwell
2021-09-27  0:16 Stephen Rothwell
     [not found] <PH0PR11MB5126EFEDB65650EFC3368981D3749@PH0PR11MB5126.namprd11.prod.outlook.com>
2021-04-08  4:57 ` Stephen Rothwell
2021-04-08  3:59 Stephen Rothwell
2019-10-18  0:13 Stephen Rothwell
2015-09-14  0:14 Stephen Rothwell
2015-09-14  0:22 ` Stephen Rothwell
2015-09-22  1:20   ` Stephen Rothwell
2015-09-22  3:42     ` David Miller
2015-08-12  8:01 Stephen Rothwell
2014-10-27  2:19 Stephen Rothwell
2014-10-28 14:49 ` Johan Hedberg
2012-09-19  1:45 Stephen Rothwell
2012-02-22  1:21 Stephen Rothwell
2012-02-22  1:29 ` David Miller
2011-12-21  2:19 Stephen Rothwell
2011-04-28  1:41 Stephen Rothwell
2011-04-28  4:12 ` Gustavo F. Padovan
2011-02-15  2:16 Stephen Rothwell
2011-02-15 12:48 ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727134433.1c4ea34e@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=alainm@chromium.org \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).