From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDC9C433F1 for ; Mon, 27 Jul 2020 14:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCEF5207FC for ; Mon, 27 Jul 2020 14:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858848; bh=ZBjwUVbaiLu8cbZf0dieYqykVNN/NZ6iX7h+k5LliDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W+fFyoG5kHwZEMuPf4gmAgR/Zdcwp4eKBtnHSjbAWW8k2vuYgkUI2SoUugxOrm8kH DHDW5PUbRqi+C/tbEZbjzDpIehJpDu15Miwf/3EbXHhcQpKBNcotyEJxkYUD/uj9Ne JrGqy0YJ7GFBgIHIhU2jqv35Ln2viJXoAVtylzRU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729238AbgG0OH0 (ORCPT ); Mon, 27 Jul 2020 10:07:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:55990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728780AbgG0OHW (ORCPT ); Mon, 27 Jul 2020 10:07:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6170D20775; Mon, 27 Jul 2020 14:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858842; bh=ZBjwUVbaiLu8cbZf0dieYqykVNN/NZ6iX7h+k5LliDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KVqQpYf8m1oMzFJeZU/JtWnkU5NSuFmQg0/8jNsEt7wHXy3a2J52YRGKr+BZkKk+5 B8UJ1DkT2+CUo5mBMu9hOWbvjGxDi0TL8R5hJldEqdQ4Qd0amB/s+DO3KCWthSfmdd rrkS+y4umZZFgEMzb9NBMVHlmgdbBGQDIfOyfNAQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Andrew Lunn , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 09/64] net: sky2: initialize return of gm_phy_read Date: Mon, 27 Jul 2020 16:03:48 +0200 Message-Id: <20200727134911.497957172@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134911.020675249@linuxfoundation.org> References: <20200727134911.020675249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix [ Upstream commit 28b18e4eb515af7c6661c3995c6e3c34412c2874 ] clang static analysis flags this garbage return drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return v; ^~~~~~~~ static inline u16 gm_phy_read( ... { u16 v; __gm_phy_read(hw, port, reg, &v); return v; } __gm_phy_read can return without setting v. So handle similar to skge.c's gm_phy_read, initialize v. Signed-off-by: Tom Rix Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 5046efdad5390..34ae4bf6e7162 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -215,7 +215,7 @@ io_error: static inline u16 gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg) { - u16 v; + u16 v = 0; __gm_phy_read(hw, port, reg, &v); return v; } -- 2.25.1