From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA9A7C433FB for ; Mon, 27 Jul 2020 14:10:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82BA722B4B for ; Mon, 27 Jul 2020 14:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859034; bh=r9m2u3fFRZQaAQ2EmZjr12wYwtTC6YK4ob/28+R+PpI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TYx0Ch8D/puDQb2OvkimRLpJ8+lOwk8Db1LueqqMw7a8HD4hzpmRtuSuE+urwER1d Cw51hhjNMAmhp28e40vRy1iU7NC2HKkbOJCkd1fMSDMpvgSlViuVoDHix75XU34YoL 6sJaPsEZgl1EVaea14k/UfVcN40bQNOK2fiZ72Bc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729862AbgG0OKb (ORCPT ); Mon, 27 Jul 2020 10:10:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:33198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729843AbgG0OKZ (ORCPT ); Mon, 27 Jul 2020 10:10:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FED02173E; Mon, 27 Jul 2020 14:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859024; bh=r9m2u3fFRZQaAQ2EmZjr12wYwtTC6YK4ob/28+R+PpI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f1U0HLUOg5Ze1fW/9cdzKAn33uSiqfgAGRHN69ieHj4sxOFF/1qofCy/y9YimbCBj Jns/sUV/lOWUjO7NNfJ0qG4pOIL2Q+McxCUw6LKaBmyX2skZ4p8jxlEXDDdvh5Lel2 1luHnnaqU6zzj+WmOoM4BQ0N0E7HTXCobT5/7eoA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liu Jian , Michael Hennerich , Stefan Schmidt , Sasha Levin Subject: [PATCH 4.19 30/86] ieee802154: fix one possible memleak in adf7242_probe Date: Mon, 27 Jul 2020 16:04:04 +0200 Message-Id: <20200727134915.953736595@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134914.312934924@linuxfoundation.org> References: <20200727134914.312934924@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liu Jian [ Upstream commit 66673f96f0f968b991dc38be06102246919c663c ] When probe fail, we should destroy the workqueue. Fixes: 2795e8c25161 ("net: ieee802154: fix a potential NULL pointer dereference") Signed-off-by: Liu Jian Acked-by: Michael Hennerich Link: https://lore.kernel.org/r/20200717090121.2143-1-liujian56@huawei.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- drivers/net/ieee802154/adf7242.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index cd6b95e673a58..71be8524cca87 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -1270,7 +1270,7 @@ static int adf7242_probe(struct spi_device *spi) WQ_MEM_RECLAIM); if (unlikely(!lp->wqueue)) { ret = -ENOMEM; - goto err_hw_init; + goto err_alloc_wq; } ret = adf7242_hw_init(lp); @@ -1302,6 +1302,8 @@ static int adf7242_probe(struct spi_device *spi) return ret; err_hw_init: + destroy_workqueue(lp->wqueue); +err_alloc_wq: mutex_destroy(&lp->bmux); ieee802154_free_hw(lp->hw); -- 2.25.1