From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D225DC433E3 for ; Mon, 27 Jul 2020 14:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A597A21744 for ; Mon, 27 Jul 2020 14:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859036; bh=DKPMavGPBrYM78YOsHIPRxg7fswAFpWf5gmyCUqE340=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aPj+f4wVD9iygFJMOM9d+b0RTbJXo5hfi54rhz3bNwUflm5cg7X2xp1v5UErcuazP TA6uI6oW7g2LOiJu/i72bL6dNOsJFiGuoq0Hi3WrtNljsFikY6XW97qBZLX8NNYKxa 2LtUpqsXsuoIHMtJe+BzMHiIR1dtbkxtudsMo9F4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729869AbgG0OKf (ORCPT ); Mon, 27 Jul 2020 10:10:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:33296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729851AbgG0OK2 (ORCPT ); Mon, 27 Jul 2020 10:10:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4EBA2073E; Mon, 27 Jul 2020 14:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859027; bh=DKPMavGPBrYM78YOsHIPRxg7fswAFpWf5gmyCUqE340=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ugkw8AXWrSltSCWzdiW/grtxd0MhxXfhp/sGvyAqTrZFiz3J3E4ExCjffhuBzVIz4 fx2G+Oze4UzOMf6bDk/48/0l8aN0xLDMUVvvd3rS3Ou1tOB5DpNq92JImsvlZcnciA gV2OkkH/FOSRjo9fBlnt03EtycD9Ob9DLcan4/6Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Beniamino Galvani , Taehee Yoo , Jay Vosburgh , Cong Wang , "David S. Miller" , Sasha Levin , syzbot+bbc3a11c4da63c1b74d6@syzkaller.appspotmail.com Subject: [PATCH 4.19 39/86] bonding: check return value of register_netdevice() in bond_newlink() Date: Mon, 27 Jul 2020 16:04:13 +0200 Message-Id: <20200727134916.390664502@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134914.312934924@linuxfoundation.org> References: <20200727134914.312934924@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cong Wang [ Upstream commit c75d1d5248c0c97996051809ad0e9f154ba5d76e ] Very similar to commit 544f287b8495 ("bonding: check error value of register_netdevice() immediately"), we should immediately check the return value of register_netdevice() before doing anything else. Fixes: 005db31d5f5f ("bonding: set carrier off for devices created through netlink") Reported-and-tested-by: syzbot+bbc3a11c4da63c1b74d6@syzkaller.appspotmail.com Cc: Beniamino Galvani Cc: Taehee Yoo Cc: Jay Vosburgh Signed-off-by: Cong Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/bonding/bond_netlink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c index 6b9ad86732188..fbcd8a752ee70 100644 --- a/drivers/net/bonding/bond_netlink.c +++ b/drivers/net/bonding/bond_netlink.c @@ -451,11 +451,10 @@ static int bond_newlink(struct net *src_net, struct net_device *bond_dev, return err; err = register_netdevice(bond_dev); - - netif_carrier_off(bond_dev); if (!err) { struct bonding *bond = netdev_priv(bond_dev); + netif_carrier_off(bond_dev); bond_work_init_all(bond); } -- 2.25.1