linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, Ingo Molnar <mingo@kernel.org>,
	sfr@canb.auug.org.au
Subject: Re: [PATCH v2] sched,tracing: Convert to sched_set_fifo()
Date: Mon, 27 Jul 2020 16:56:14 -0400	[thread overview]
Message-ID: <20200727165614.5d0f4346@oasis.local.home> (raw)
In-Reply-To: <20200725165816.GE10769@hirez.programming.kicks-ass.net>

On Sat, 25 Jul 2020 18:58:16 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Jul 24, 2020 at 06:18:46PM -0400, Steven Rostedt wrote:
> > On Fri, 24 Jul 2020 23:50:03 +0200
> > peterz@infradead.org wrote:
> >   
> > > -	if (producer_fifo < 0)
> > > +	if (producer_fifo)
> > > +		trace_printk("Running Producer at SCHED_FIFO %s\n",
> > > +			     consumer_fifo == 1 ? "low" : "high");  
> > 
> > I'm going to take cut-and-paste away from you!  
> 
> Well, yes, I said so, I also already have it fixed.

I thought you're comment on IRC was about v1, as I read it before
seeing v2.

> 
> Aside from that, is the patch ok?

Beside this, yes.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

  reply	other threads:[~2020-07-27 20:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 14:15 [tip:sched/fifo 44/45] ERROR: modpost: "sched_setscheduler" undefined! kernel test robot
2020-07-09 12:45 ` Peter Zijlstra
2020-07-09 15:58   ` Steven Rostedt
2020-07-20 21:49     ` Peter Zijlstra
2020-07-20 22:19       ` Steven Rostedt
2020-07-21  8:36         ` peterz
2020-07-21 10:13           ` Qais Yousef
2020-07-29 10:23             ` Dietmar Eggemann
2020-07-29 10:38               ` Qais Yousef
2020-07-30 15:29               ` Qais Yousef
2020-07-21 13:30           ` Steven Rostedt
2020-07-24 21:39       ` [PATCH] sched,tracing: Convert to sched_set_fifo() peterz
2020-07-24 21:46         ` Steven Rostedt
2020-07-24 21:50           ` [PATCH v2] " peterz
2020-07-24 22:18             ` Steven Rostedt
2020-07-25 16:58               ` Peter Zijlstra
2020-07-27 20:56                 ` Steven Rostedt [this message]
2020-07-29 10:54       ` [tip: sched/fifo] " tip-bot2 for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727165614.5d0f4346@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).