From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1CFC433E3 for ; Mon, 27 Jul 2020 23:25:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE70620786 for ; Mon, 27 Jul 2020 23:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892304; bh=pOfsrTcmGvxL4USw2Stgyi30wbEKbO6BwaawdDfIvHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FsTEE52lIw2dbjLmo82UnOkuikQv22rsTGTgHW8+f5jqpGLoRenSB2qtxmZqQlk9j waOW7DoScl5QRmM8cKPRh16Df/P0kgFzQ8ISNQWNdeplQFG0Y7OG2nF49Ja3ghDlS4 ripr4LN0zMmZfdrPuu/E6BGCaNG39V8RorRoolnw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728478AbgG0XZD (ORCPT ); Mon, 27 Jul 2020 19:25:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:36178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728437AbgG0XY4 (ORCPT ); Mon, 27 Jul 2020 19:24:56 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67FCC21744; Mon, 27 Jul 2020 23:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892296; bh=pOfsrTcmGvxL4USw2Stgyi30wbEKbO6BwaawdDfIvHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VPz5dEa4vlYPDsQ48MWuEJjsyBkdcj3O6OBy/kSEqNhuLBHjWCa5zr9hqXWx97Xfx JJ/nkYjG0NEU209h72wvLWr+BjvMJJ/r2mVfUgsnZDLDcbMT9l9TzO1bj4MnRkat2J Bhbcofg88638u6raZLT3s/2n5HDxjkEKbe3+yxlQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 09/10] cxgb4: add missing release on skb in uld_send() Date: Mon, 27 Jul 2020 19:24:42 -0400 Message-Id: <20200727232443.718000-9-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200727232443.718000-1-sashal@kernel.org> References: <20200727232443.718000-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit e6827d1abdc9b061a57d7b7d3019c4e99fabea2f ] In the implementation of uld_send(), the skb is consumed on all execution paths except one. Release skb when returning NET_XMIT_DROP. Signed-off-by: Navid Emamdoost Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 3d4a765e9e61d..7801f2aeeb30e 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c @@ -2367,6 +2367,7 @@ static inline int uld_send(struct adapter *adap, struct sk_buff *skb, txq_info = adap->sge.uld_txq_info[tx_uld_type]; if (unlikely(!txq_info)) { WARN_ON(true); + kfree_skb(skb); return NET_XMIT_DROP; } -- 2.25.1