linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Roger Pau Monne <roger.pau@citrix.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dan Carpenter <error27@gmail.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory
Date: Tue, 28 Jul 2020 02:04:57 +0800	[thread overview]
Message-ID: <202007280145.X4mWvv2r%lkp@intel.com> (raw)
In-Reply-To: <20200727091342.52325-5-roger.pau@citrix.com>

[-- Attachment #1: Type: text/plain, Size: 9543 bytes --]

Hi Roger,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on linus/master v5.8-rc7 next-20200727]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Roger-Pau-Monne/xen-balloon-fixes-for-memory-hotplug/20200727-171643
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: i386-randconfig-a001-20200727 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/xen/xen.h:61,
                    from drivers/xen/xen-front-pgdir-shbuf.c:18:
   include/xen/balloon.h:8:8: error: redefinition of 'struct balloon_stats'
       8 | struct balloon_stats {
         |        ^~~~~~~~~~~~~
   In file included from drivers/xen/xen-front-pgdir-shbuf.c:17:
   include/xen/balloon.h:8:8: note: originally defined here
       8 | struct balloon_stats {
         |        ^~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from drivers/xen/xen-front-pgdir-shbuf.c:18:
   include/xen/balloon.h:23:29: error: conflicting types for 'balloon_stats'
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
   In file included from drivers/xen/xen-front-pgdir-shbuf.c:17:
   include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from drivers/xen/xen-front-pgdir-shbuf.c:18:
>> include/xen/balloon.h:33:20: error: redefinition of 'xen_balloon_init'
      33 | static inline void xen_balloon_init(void)
         |                    ^~~~~~~~~~~~~~~~
   In file included from drivers/xen/xen-front-pgdir-shbuf.c:17:
   include/xen/balloon.h:33:20: note: previous definition of 'xen_balloon_init' was here
      33 | static inline void xen_balloon_init(void)
         |                    ^~~~~~~~~~~~~~~~
--
   In file included from drivers/xen/balloon.c:71:
   include/xen/balloon.h:8:8: error: redefinition of 'struct balloon_stats'
       8 | struct balloon_stats {
         |        ^~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from drivers/xen/balloon.c:68:
   include/xen/balloon.h:8:8: note: originally defined here
       8 | struct balloon_stats {
         |        ^~~~~~~~~~~~~
   In file included from drivers/xen/balloon.c:71:
   include/xen/balloon.h:23:29: error: conflicting types for 'balloon_stats'
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from drivers/xen/balloon.c:68:
   include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
   In file included from drivers/xen/balloon.c:71:
>> include/xen/balloon.h:33:20: error: redefinition of 'xen_balloon_init'
      33 | static inline void xen_balloon_init(void)
         |                    ^~~~~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from drivers/xen/balloon.c:68:
   include/xen/balloon.h:33:20: note: previous definition of 'xen_balloon_init' was here
      33 | static inline void xen_balloon_init(void)
         |                    ^~~~~~~~~~~~~~~~
   drivers/xen/balloon.c:138:22: error: conflicting types for 'balloon_stats'
     138 | struct balloon_stats balloon_stats;
         |                      ^~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from drivers/xen/balloon.c:68:
   include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
   In file included from include/linux/linkage.h:7,
                    from include/linux/kernel.h:8,
                    from arch/x86/include/asm/percpu.h:45,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/node.h:18,
                    from include/linux/cpu.h:17,
                    from drivers/xen/balloon.c:41:
   drivers/xen/balloon.c:139:19: error: conflicting types for 'balloon_stats'
     139 | EXPORT_SYMBOL_GPL(balloon_stats);
         |                   ^~~~~~~~~~~~~
   include/linux/export.h:98:21: note: in definition of macro '___EXPORT_SYMBOL'
      98 |  extern typeof(sym) sym;       \
         |                     ^~~
   include/linux/export.h:155:34: note: in expansion of macro '__EXPORT_SYMBOL'
     155 | #define _EXPORT_SYMBOL(sym, sec) __EXPORT_SYMBOL(sym, sec, "")
         |                                  ^~~~~~~~~~~~~~~
   include/linux/export.h:159:33: note: in expansion of macro '_EXPORT_SYMBOL'
     159 | #define EXPORT_SYMBOL_GPL(sym)  _EXPORT_SYMBOL(sym, "_gpl")
         |                                 ^~~~~~~~~~~~~~
   drivers/xen/balloon.c:139:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
     139 | EXPORT_SYMBOL_GPL(balloon_stats);
         | ^~~~~~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from drivers/xen/balloon.c:68:
   include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
--
   In file included from include/xen/xen.h:61,
                    from arch/x86/include/asm/xen/events.h:5,
                    from include/xen/events.h:13,
                    from drivers/xen/xenbus/xenbus_client.c:44:
   include/xen/balloon.h:8:8: error: redefinition of 'struct balloon_stats'
       8 | struct balloon_stats {
         |        ^~~~~~~~~~~~~
   In file included from drivers/xen/xenbus/xenbus_client.c:43:
   include/xen/balloon.h:8:8: note: originally defined here
       8 | struct balloon_stats {
         |        ^~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from arch/x86/include/asm/xen/events.h:5,
                    from include/xen/events.h:13,
                    from drivers/xen/xenbus/xenbus_client.c:44:
   include/xen/balloon.h:23:29: error: conflicting types for 'balloon_stats'
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
   In file included from drivers/xen/xenbus/xenbus_client.c:43:
   include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here
      23 | extern struct balloon_stats balloon_stats;
         |                             ^~~~~~~~~~~~~
   In file included from include/xen/xen.h:61,
                    from arch/x86/include/asm/xen/events.h:5,
                    from include/xen/events.h:13,
                    from drivers/xen/xenbus/xenbus_client.c:44:
>> include/xen/balloon.h:33:20: error: redefinition of 'xen_balloon_init'
      33 | static inline void xen_balloon_init(void)
         |                    ^~~~~~~~~~~~~~~~
   In file included from drivers/xen/xenbus/xenbus_client.c:43:
   include/xen/balloon.h:33:20: note: previous definition of 'xen_balloon_init' was here
      33 | static inline void xen_balloon_init(void)
         |                    ^~~~~~~~~~~~~~~~
   drivers/xen/xenbus/xenbus_client.c: In function 'xenbus_va_dev_error':
   drivers/xen/xenbus/xenbus_client.c:292:2: warning: function 'xenbus_va_dev_error' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     292 |  vsnprintf(printf_buffer + len, PRINTF_BUFFER_SIZE - len, fmt, ap);
         |  ^~~~~~~~~

vim +/xen_balloon_init +33 include/xen/balloon.h

803eb047a28d23 Daniel De Graaf       2011-03-14  22  
803eb047a28d23 Daniel De Graaf       2011-03-14 @23  extern struct balloon_stats balloon_stats;
803eb047a28d23 Daniel De Graaf       2011-03-14  24  
803eb047a28d23 Daniel De Graaf       2011-03-14  25  void balloon_set_new_target(unsigned long target);
b6f3067985f12d Konrad Rzeszutek Wilk 2011-03-15  26  
81b286e0f1fe52 David Vrabel          2015-06-25  27  int alloc_xenballooned_pages(int nr_pages, struct page **pages);
b6f3067985f12d Konrad Rzeszutek Wilk 2011-03-15  28  void free_xenballooned_pages(int nr_pages, struct page **pages);
a50777c791031d Dan Magenheimer       2011-07-08  29  
96edd61dcf4436 Juergen Gross         2017-07-10  30  #ifdef CONFIG_XEN_BALLOON
96edd61dcf4436 Juergen Gross         2017-07-10  31  void xen_balloon_init(void);
96edd61dcf4436 Juergen Gross         2017-07-10  32  #else
96edd61dcf4436 Juergen Gross         2017-07-10 @33  static inline void xen_balloon_init(void)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33683 bytes --]

  parent reply	other threads:[~2020-07-27 18:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  9:13 [PATCH v3 0/4] xen/balloon: fixes for memory hotplug Roger Pau Monne
2020-07-27  9:13 ` [PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path Roger Pau Monne
2020-08-03  6:18   ` Jürgen Groß
2020-07-27  9:13 ` [PATCH v3 2/4] xen/balloon: make the balloon wait interruptible Roger Pau Monne
2020-08-03  6:18   ` Jürgen Groß
2020-07-27  9:13 ` [PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE" Roger Pau Monne
2020-08-03  6:19   ` Jürgen Groß
2020-07-27  9:13 ` [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory Roger Pau Monne
2020-07-27 15:09   ` Jürgen Groß
2020-07-27 18:04   ` kernel test robot [this message]
2020-07-28 11:42   ` [PATCH] xen/balloon: add header guard Roger Pau Monne
2020-07-28 13:56     ` Boris Ostrovsky
2020-07-28 16:48   ` [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory Julien Grall
2020-07-28 16:59     ` Roger Pau Monné
2020-07-28 17:06       ` Andrew Cooper
2020-07-28 17:42         ` Roger Pau Monné
2020-07-28 17:12       ` Julien Grall
2020-07-28 17:44         ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202007280145.X4mWvv2r%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=airlied@linux.ie \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel@ffwll.ch \
    --cc=error27@gmail.com \
    --cc=jgross@suse.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).