From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Petr Mladek <pmladek@suse.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>
Subject: Re: linux-next: build failure after merge of the printk tree
Date: Tue, 28 Jul 2020 11:51:19 +1000 [thread overview]
Message-ID: <20200728015119.GA11428@gondor.apana.org.au> (raw)
In-Reply-To: <20200728114927.4590731f@canb.auug.org.au>
On Tue, Jul 28, 2020 at 11:49:27AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the printk tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/linux/printk.h:10,
> from include/linux/kernel.h:15,
> from include/linux/list.h:9,
> from include/linux/lockdep.h:43,
> from include/linux/spinlock_types.h:18,
> from include/linux/genalloc.h:32,
> from drivers/soc/fsl/qe/qe_common.c:16:
> include/linux/ratelimit_types.h:16:2: error: unknown type name 'raw_spinlock_t'
> 16 | raw_spinlock_t lock; /* protect the state */
> | ^~~~~~~~~~~~~~
> In file included from include/linux/wait.h:9,
> from include/linux/pid.h:6,
> from include/linux/sched.h:14,
> from include/linux/ratelimit.h:6,
> from include/linux/dev_printk.h:16,
> from include/linux/device.h:15,
> from include/linux/node.h:18,
> from include/linux/cpu.h:17,
> from include/linux/of_device.h:5,
> from drivers/soc/fsl/qe/qe_common.c:19:
> include/linux/ratelimit.h: In function 'ratelimit_state_init':
> include/linux/ratelimit.h:14:21: error: passing argument 1 of '__raw_spin_lock_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 14 | raw_spin_lock_init(&rs->lock);
> include/linux/spinlock.h:102:24: note: in definition of macro 'raw_spin_lock_init'
> 102 | __raw_spin_lock_init((lock), #lock, &__key, LD_WAIT_SPIN); \
> | ^~~~
> include/linux/spinlock.h:95:52: note: expected 'raw_spinlock_t *' {aka 'struct raw_spinlock *'} but argument is of type 'int *'
> 95 | extern void __raw_spin_lock_init(raw_spinlock_t *lock, const char *name,
> | ~~~~~~~~~~~~~~~~^~~~
>
> Caused by commit
>
> b4a461e72bcb ("printk: Make linux/printk.h self-contained")
>
> This *may* be interacting with other include file changes in linux-next.
>
> I have reverted that commit for today.
This patch depends on two patches in the tips tree. I presume
this build test was done without the tips tree, right?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-07-28 1:51 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 1:49 linux-next: build failure after merge of the printk tree Stephen Rothwell
2020-07-28 1:51 ` Herbert Xu [this message]
2020-07-28 2:21 ` Stephen Rothwell
2020-07-28 1:54 ` Sergey Senozhatsky
2020-07-28 2:24 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2023-01-15 23:23 Stephen Rothwell
2023-01-16 15:54 ` Petr Mladek
2022-11-21 0:00 Stephen Rothwell
2022-11-21 13:42 ` Petr Mladek
2021-07-20 7:43 Stephen Rothwell
2021-07-20 8:17 ` Naresh Kamboju
2021-07-20 12:28 ` Chris Down
2021-07-21 8:57 ` Petr Mladek
2021-07-21 11:22 ` Chris Down
2021-07-21 12:49 ` Petr Mladek
2021-07-22 23:01 ` Stephen Rothwell
2021-07-23 11:14 ` Petr Mladek
2021-07-23 12:14 ` Chris Down
2020-07-29 11:03 Stephen Rothwell
2020-07-29 11:47 ` Herbert Xu
2020-06-21 3:15 Stephen Rothwell
2020-06-21 3:26 ` Herbert Xu
2020-06-23 0:26 ` Stephen Rothwell
2020-06-23 12:16 ` Petr Mladek
2020-06-23 12:19 ` Herbert Xu
2020-06-23 14:28 ` Petr Mladek
2020-06-23 15:17 ` Peter Zijlstra
2020-06-24 8:22 ` Petr Mladek
2020-06-24 0:20 ` Herbert Xu
2020-06-24 8:19 ` Petr Mladek
2020-06-24 8:21 ` Herbert Xu
2019-12-05 22:25 Stephen Rothwell
2019-12-06 10:03 ` Petr Mladek
2018-03-02 5:07 Stephen Rothwell
2018-03-02 15:54 ` Petr Mladek
2018-03-03 2:43 ` Stephen Rothwell
2018-03-03 14:47 ` Sergey Senozhatsky
2018-03-05 3:20 ` Dave Young
2018-03-05 5:27 ` Greentime Hu
2018-03-05 5:41 ` Sergey Senozhatsky
2018-03-05 12:25 ` Petr Mladek
2017-12-07 0:37 Stephen Rothwell
2017-12-07 1:26 ` Sergey Senozhatsky
2017-12-07 13:12 ` Petr Mladek
2017-12-06 3:23 Stephen Rothwell
2017-12-06 4:28 ` Sergey Senozhatsky
2017-12-06 10:17 ` Petr Mladek
2017-12-06 10:39 ` Sergey Senozhatsky
2017-12-07 1:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728015119.GA11428@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).