From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 708F4C433E0 for ; Tue, 28 Jul 2020 12:27:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F6992070B for ; Tue, 28 Jul 2020 12:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595939225; bh=N4SOQRKaRTIyJZBjBFixSfY3mkt05IKtAPjTslO6urY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yzNJwEwbNboNFhf3RaphI8M/v2MRuzROWHQAdkseGa+EquyZ9HqiRjoxeY7b65Zm7 ZesY8NgaPAVACQi8iecyLw9LOUe0AVKsI9EeT2qOCu84m9aPe8uD+jDo5Z1UB/vOPW st87MMFIKgy+9sPgbIqTAxeAEfx7ovJWWQPxlb1s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729503AbgG1M1C (ORCPT ); Tue, 28 Jul 2020 08:27:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:40366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbgG1M1B (ORCPT ); Tue, 28 Jul 2020 08:27:01 -0400 Received: from quaco.ghostprotocols.net (179.176.1.55.dynamic.adsl.gvt.net.br [179.176.1.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39C43206D4; Tue, 28 Jul 2020 12:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595939221; bh=N4SOQRKaRTIyJZBjBFixSfY3mkt05IKtAPjTslO6urY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pduy+mKNwv04ARmILR0f7B+iaiH+Cq9UdVAP9MmfnNV5iaclkUrnVVeGG78bR2c93 gzNDqIQ72bCdIKXPisvjzpkKLfJ/ztFCBZHglkxFSxaY3cYlFTsihWlfqwYuoOG0Lo mtEH35O2CZHi2uPbmsW13gTGtbQinVfwqDvLYMFo= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 54747404B1; Tue, 28 Jul 2020 09:26:58 -0300 (-03) Date: Tue, 28 Jul 2020 09:26:58 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen , Kajol Jain , John Garry , "Paul A. Clarke" , Stephane Eranian Subject: Re: [PATCH 01/19] perf metric: Fix memory leak in expr__add_id function Message-ID: <20200728122658.GH40195@kernel.org> References: <20200719181320.785305-1-jolsa@kernel.org> <20200719181320.785305-2-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Jul 19, 2020 at 02:41:46PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:13 AM Jiri Olsa wrote: > > > > Arnaldo found that we don't release value data in case the > > hashmap__set fails. Releasing it in case of an error. > > > > Reported-by: Arnaldo Carvalho de Melo > > Signed-off-by: Jiri Olsa > > Acked-by: Ian Rogers Thanks, applied. - Arnaldo