From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4940C433DF for ; Tue, 28 Jul 2020 12:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AE342070B for ; Tue, 28 Jul 2020 12:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595939558; bh=ZbZwYZdM78qSDbFfYE+8AstHXUYz25gnm4B0I/ih8Fg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GXJwHyI5Eitbn+IyZfx5BLnxDuPDA0i+VYXxN6bTbnXmg6VWfxzSOFklEwcgtl7ZB 4BpDLXLy8pfjxNg90FcC8cxQNPqcCajnuV5UQIJyjOTj+6B6/rYHRGc59AIceBsRN1 9vMrFPYzQ3azIYbURfWkQUWBVQWRHjeAIFPH78IA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729730AbgG1Mch (ORCPT ); Tue, 28 Jul 2020 08:32:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:47668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729723AbgG1Mcf (ORCPT ); Tue, 28 Jul 2020 08:32:35 -0400 Received: from quaco.ghostprotocols.net (179.176.1.55.dynamic.adsl.gvt.net.br [179.176.1.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E53B22074F; Tue, 28 Jul 2020 12:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595939554; bh=ZbZwYZdM78qSDbFfYE+8AstHXUYz25gnm4B0I/ih8Fg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wwSkO/lGGf4VTjDXl7HsrnGvqDlRAgHTFIZ7NltfaJRXgUBSXQu3VBbKTPzUQYXRJ v2EvnpVQNWnumg+MzD4rVatWI4tJpPDTkJI+11clTa1RmFdbEKXia6AK74L1bzWK0t dyYW7qJ2ucO85heVWTFp5yV8DHDIJPsR6CJrxAiw= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E9ED4404B1; Tue, 28 Jul 2020 09:32:31 -0300 (-03) Date: Tue, 28 Jul 2020 09:32:31 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen , Kajol Jain , John Garry , "Paul A. Clarke" , Stephane Eranian Subject: Re: [PATCH 10/19] perf metric: Add referenced metrics to hash data Message-ID: <20200728123231.GQ40195@kernel.org> References: <20200719181320.785305-1-jolsa@kernel.org> <20200719181320.785305-11-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Jul 19, 2020 at 03:32:26PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:14 AM Jiri Olsa wrote: > > > > Adding referenced metrics to the parsing context so they > > can be resolved during the metric processing. > > > > Adding expr__add_ref function to store referenced metrics > > into parse context. > > > > Signed-off-by: Jiri Olsa > > Acked-by: Ian Rogers Thanks, applied. - Arnaldo > Thanks, > Ian > > > --- > > tools/perf/util/expr.c | 54 +++++++++++++++++++++++++++++++++++ > > tools/perf/util/expr.h | 13 ++++++++- > > tools/perf/util/stat-shadow.c | 20 +++++++++---- > > 3 files changed, 80 insertions(+), 7 deletions(-) > > > > diff --git a/tools/perf/util/expr.c b/tools/perf/util/expr.c > > index f726211f49d4..d3997c2b4a90 100644 > > --- a/tools/perf/util/expr.c > > +++ b/tools/perf/util/expr.c > > @@ -4,10 +4,14 @@ > > #include > > #include > > #include > > +#include "metricgroup.h" > > +#include "debug.h" > > #include "expr.h" > > #include "expr-bison.h" > > #include "expr-flex.h" > > #include > > +#include > > +#include > > > > #ifdef PARSER_DEBUG > > extern int expr_debug; > > @@ -63,6 +67,7 @@ int expr__add_id_val(struct expr_parse_ctx *ctx, const char *id, double val) > > if (!data_ptr) > > return -ENOMEM; > > data_ptr->val = val; > > + data_ptr->is_ref = false; > > > > ret = hashmap__set(&ctx->ids, id, data_ptr, > > (const void **)&old_key, (void **)&old_data); > > @@ -73,6 +78,55 @@ int expr__add_id_val(struct expr_parse_ctx *ctx, const char *id, double val) > > return ret; > > } > > > > +int expr__add_ref(struct expr_parse_ctx *ctx, struct metric_ref *ref) > > +{ > > + struct expr_id_data *data_ptr = NULL, *old_data = NULL; > > + char *old_key = NULL; > > + char *name, *p; > > + int ret; > > + > > + data_ptr = zalloc(sizeof(*data_ptr)); > > + if (!data_ptr) > > + return -ENOMEM; > > + > > + name = strdup(ref->metric_name); > > + if (!name) { > > + free(data_ptr); > > + return -ENOMEM; > > + } > > + > > + /* > > + * The jevents tool converts all metric expressions > > + * to lowercase, including metric references, hence > > + * we need to add lowercase name for metric, so it's > > + * properly found. > > + */ > > + for (p = name; *p; p++) > > + *p = tolower(*p); > > + > > + /* > > + * Intentionally passing just const char pointers, > > + * originally from 'struct pmu_event' object. > > + * We don't need to change them, so there's no > > + * need to create our own copy. > > + */ > > + data_ptr->ref.metric_name = ref->metric_name; > > + data_ptr->ref.metric_expr = ref->metric_expr; > > + data_ptr->is_ref = true; > > + > > + ret = hashmap__set(&ctx->ids, name, data_ptr, > > + (const void **)&old_key, (void **)&old_data); > > + if (ret) > > + free(data_ptr); > > + > > + pr_debug2("adding ref metric %s: %s\n", > > + ref->metric_name, ref->metric_expr); > > + > > + free(old_key); > > + free(old_data); > > + return ret; > > +} > > + > > int expr__get_id(struct expr_parse_ctx *ctx, const char *id, > > struct expr_id_data **data) > > { > > diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h > > index 2462abd0ac65..81d04ff7f857 100644 > > --- a/tools/perf/util/expr.h > > +++ b/tools/perf/util/expr.h > > @@ -11,12 +11,22 @@ > > #include "util/hashmap.h" > > //#endif > > > > +struct metric_ref; > > + > > struct expr_parse_ctx { > > struct hashmap ids; > > }; > > > > struct expr_id_data { > > - double val; > > + union { > > + double val; > > + struct { > > + const char *metric_name; > > + const char *metric_expr; > > + } ref; > > + }; > > + > > + bool is_ref; > > }; > > > > struct expr_scanner_ctx { > > @@ -29,6 +39,7 @@ void expr__ctx_clear(struct expr_parse_ctx *ctx); > > void expr__del_id(struct expr_parse_ctx *ctx, const char *id); > > int expr__add_id(struct expr_parse_ctx *ctx, const char *id); > > int expr__add_id_val(struct expr_parse_ctx *ctx, const char *id, double val); > > +int expr__add_ref(struct expr_parse_ctx *ctx, struct metric_ref *ref); > > int expr__get_id(struct expr_parse_ctx *ctx, const char *id, > > struct expr_id_data **data); > > int expr__parse(double *final_val, struct expr_parse_ctx *ctx, > > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > > index fc9ac4b4218e..e1ba6c1b916a 100644 > > --- a/tools/perf/util/stat-shadow.c > > +++ b/tools/perf/util/stat-shadow.c > > @@ -731,13 +731,14 @@ static void print_smi_cost(struct perf_stat_config *config, > > } > > > > static int prepare_metric(struct evsel **metric_events, > > + struct metric_ref *metric_refs, > > struct expr_parse_ctx *pctx, > > int cpu, > > struct runtime_stat *st) > > { > > double scale; > > char *n, *pn; > > - int i; > > + int i, j, ret; > > > > expr__ctx_init(pctx); > > for (i = 0; metric_events[i]; i++) { > > @@ -778,12 +779,19 @@ static int prepare_metric(struct evsel **metric_events, > > expr__add_id_val(pctx, n, avg_stats(stats)*scale); > > } > > > > + for (j = 0; metric_refs && metric_refs[j].metric_name; j++) { > > + ret = expr__add_ref(pctx, &metric_refs[j]); > > + if (ret) > > + return ret; > > + } > > + > > return i; > > } > > > > static void generic_metric(struct perf_stat_config *config, > > const char *metric_expr, > > struct evsel **metric_events, > > + struct metric_ref *metric_refs, > > char *name, > > const char *metric_name, > > const char *metric_unit, > > @@ -798,7 +806,7 @@ static void generic_metric(struct perf_stat_config *config, > > int i; > > void *ctxp = out->ctx; > > > > - i = prepare_metric(metric_events, &pctx, cpu, st); > > + i = prepare_metric(metric_events, metric_refs, &pctx, cpu, st); > > if (i < 0) > > return; > > > > @@ -847,7 +855,7 @@ double test_generic_metric(struct metric_expr *mexp, int cpu, struct runtime_sta > > struct expr_parse_ctx pctx; > > double ratio; > > > > - if (prepare_metric(mexp->metric_events, &pctx, cpu, st) < 0) > > + if (prepare_metric(mexp->metric_events, mexp->metric_refs, &pctx, cpu, st) < 0) > > return 0.; > > > > if (expr__parse(&ratio, &pctx, mexp->metric_expr, 1)) > > @@ -1064,8 +1072,8 @@ void perf_stat__print_shadow_stats(struct perf_stat_config *config, > > else > > print_metric(config, ctxp, NULL, NULL, name, 0); > > } else if (evsel->metric_expr) { > > - generic_metric(config, evsel->metric_expr, evsel->metric_events, evsel->name, > > - evsel->metric_name, NULL, 1, cpu, out, st); > > + generic_metric(config, evsel->metric_expr, evsel->metric_events, NULL, > > + evsel->name, evsel->metric_name, NULL, 1, cpu, out, st); > > } else if (runtime_stat_n(st, STAT_NSECS, 0, cpu) != 0) { > > char unit = 'M'; > > char unit_buf[10]; > > @@ -1093,7 +1101,7 @@ void perf_stat__print_shadow_stats(struct perf_stat_config *config, > > if (num++ > 0) > > out->new_line(config, ctxp); > > generic_metric(config, mexp->metric_expr, mexp->metric_events, > > - evsel->name, mexp->metric_name, > > + mexp->metric_refs, evsel->name, mexp->metric_name, > > mexp->metric_unit, mexp->runtime, cpu, out, st); > > } > > } > > -- > > 2.25.4 > > -- - Arnaldo