From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D496C433E4 for ; Tue, 28 Jul 2020 13:07:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4E45206D4 for ; Tue, 28 Jul 2020 13:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="TAVEa3Yf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729966AbgG1NHK (ORCPT ); Tue, 28 Jul 2020 09:07:10 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:55454 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729044AbgG1NHJ (ORCPT ); Tue, 28 Jul 2020 09:07:09 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06SCvciV140200; Tue, 28 Jul 2020 13:06:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=q7GI9yh/Gh71E0hei7w55055yjUA2PBFGJh00B5hcsI=; b=TAVEa3YfpE3Fb6zQcuBqxRiQe24CPGDbZzG/KE9SLc0BAnXvv+tNDg3dzvgj81aTawmZ dfhqQ6kwde8XbaRdc5qRsDWc9Of9rLJk/pXQcji4bOp3tFThrejkcAAlf0TjChfvspdQ xEeWNlQGfRvD7JjoWwXnS1z1jNTSFxQ7EBp8MaMJIu6N/s2ZjJPYfbTsEB7xXUB4io+g sroIRwGPyOKvhF/jjDj63vqk+jf1xN5bl6d3xOGZx37d8N7vPylnKCb4lwkDjsElXJTp HsPhuEwsSccmtoWobhvEe3bfIPl5kv8/GXGe4b69owQYxoaFBI5gqeXu7h4B0xPILGkz KA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 32hu1j7bxd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Jul 2020 13:06:46 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06SD4bab142311; Tue, 28 Jul 2020 13:06:45 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 32hu5suy90-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jul 2020 13:06:45 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06SD6fSb006116; Tue, 28 Jul 2020 13:06:41 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 28 Jul 2020 06:06:41 -0700 Date: Tue, 28 Jul 2020 16:06:32 +0300 From: Dan Carpenter To: Linus Walleij Cc: Arnd Bergmann , Peilin Ye , Mauro Carvalho Chehab , Greg Kroah-Hartman , syzkaller-bugs , Hans Verkuil , Sakari Ailus , Laurent Pinchart , Vandana BN , Ezequiel Garcia , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-kernel-mentees@lists.linuxfoundation.org, Linux Media Mailing List , "linux-kernel@vger.kernel.org" Subject: Re: [Linux-kernel-mentees] [PATCH v3] media/v4l2-core: Fix kernel-infoleak in video_put_user() Message-ID: <20200728130632.GI1913@kadam> References: <20200726220557.102300-1-yepeilin.cs@gmail.com> <20200726222703.102701-1-yepeilin.cs@gmail.com> <20200727131608.GD1913@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9695 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007280099 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9695 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 clxscore=1015 mlxscore=0 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007280098 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 02:22:29PM +0200, Linus Walleij wrote: > On Mon, Jul 27, 2020 at 3:17 PM Dan Carpenter wrote: > > > Here are my latest warnings on linux-next from Friday. > > Thanks for sharing this Dan, very interesting findings. > > > drivers/gpio/gpiolib-cdev.c:473 lineevent_read() warn: check that 'ge' doesn't leak information (struct has a hole after 'id') > > We are revamping the ABI for 64bit compatibility so we are now running > pahole on our stuff. I suppose we need to think about mending this old ABI > as well. Yeah... But this one is a false positive. It's not super hard for me to silence it actually. I'll take care of it. It could be a while before I push this to the public repository though... regards, dan carpenter