From: Greg KH <gregkh@linuxfoundation.org>
To: Dhiraj Sharma <dhiraj.sharma0024@gmail.com>
Cc: devel@driverdev.osuosl.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
stern@rowland.harvard.edu, jrdr.linux@gmail.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: usbvision: fixed coding style
Date: Tue, 28 Jul 2020 17:53:11 +0200 [thread overview]
Message-ID: <20200728155311.GA4178776@kroah.com> (raw)
In-Reply-To: <CAPRy4h1Xs1JpQinnWm04dOi07Ch0RLL0U4Z5DDCKHmombXE0sA@mail.gmail.com>
On Tue, Jul 28, 2020 at 09:14:24PM +0530, Dhiraj Sharma wrote:
> Sorry, I didn't realize that I committed a mistake by not replying to
> all. It was an accidental mistake which will not be committed in
> future now.
>
> >
> > That is not needed in a changelog text.
> >
>
> Alright Sir.
>
> > Neither is this, please be specific about what you have fixed. My bot
> > should kick in soon with more specifics...
>
> Sir there were checkpatch.pl styling issues and I fixed them all
> together, so should I write a proper changelog as what all I fixed i.e
> errors and warnings thrown by checkpatch.pl
As the bot said, only do one type of thing per patch, and "fix all
checkpatch errors/warnings" is not one type of thing.
next prev parent reply other threads:[~2020-07-28 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 14:30 [PATCH] media: usbvision: fixed coding style Dhiraj Sharma
2020-07-28 14:54 ` Greg KH
2020-07-28 15:44 ` Dhiraj Sharma
2020-07-28 15:53 ` Greg KH [this message]
2020-07-28 16:43 ` Dhiraj Sharma
2020-07-28 16:58 ` Greg KH
2020-07-28 16:59 ` Dhiraj Sharma
2020-07-28 14:54 ` Greg KH
2020-07-28 15:05 ` Hans Verkuil
2020-07-28 15:47 ` Dhiraj Sharma
2020-07-28 17:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728155311.GA4178776@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=dhiraj.sharma0024@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).