From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D5FC433E1 for ; Tue, 28 Jul 2020 17:29:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97869207F5 for ; Tue, 28 Jul 2020 17:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595957356; bh=2T3mr7waKN2zzqEx10ZQKW4qYXOz5+D5jfjnMLkLR2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wUTpqaJd4nhtrvaUnVnvbwl+5+zAgJahHmg0eq7I6FhcAAp729qjoNVCUqG4YI27m NFr2VVgKU38mbfXrE968YXKXld4210RWTcPls6Y/ZKkjbiSS3Shu7Ulvjm/tBtb0j3 WIW2XTjZTRk3t3G/Kx1M7gF80XrXU9jsuuPy2YOM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732025AbgG1R3P (ORCPT ); Tue, 28 Jul 2020 13:29:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:44020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731779AbgG1R3N (ORCPT ); Tue, 28 Jul 2020 13:29:13 -0400 Received: from linux-8ccs (p57a236d4.dip0.t-ipconnect.de [87.162.54.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22C032078E; Tue, 28 Jul 2020 17:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595957353; bh=2T3mr7waKN2zzqEx10ZQKW4qYXOz5+D5jfjnMLkLR2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vVCKMUptkWj96NFd/9wAfn1anprKpA1fwfJcUu2vSpsNVfOJyrX9Kybt/aAzDWI/3 zhPgKHbFtGm4eNoNdXw3LASuth1mLDaaX/XN4AcfyVmGU2TOq0dJr129XX1ogXhViN lIysWUbEQBTENhX/MJzpx14RG9c5PDIptwAHWYT0= Date: Tue, 28 Jul 2020 19:29:08 +0200 From: Jessica Yu To: Kristen Carlson Accardi Cc: keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, "H. Peter Anvin" , arjan@linux.intel.com, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecombe@intel.com, Ard Biesheuvel , Tony Luck Subject: Re: [PATCH v4 10/10] module: Reorder functions Message-ID: <20200728172907.GA31178@linux-8ccs> References: <20200717170008.5949-1-kristen@linux.intel.com> <20200717170008.5949-11-kristen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200717170008.5949-11-kristen@linux.intel.com> X-OS: Linux linux-8ccs 5.5.0-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Kristen Carlson Accardi [17/07/20 10:00 -0700]: >Introduce a new config option to allow modules to be re-ordered >by function. This option can be enabled independently of the >kernel text KASLR or FG_KASLR settings so that it can be used >by architectures that do not support either of these features. >This option will be selected by default if CONFIG_FG_KASLR is >selected. > >If a module has functions split out into separate text sections >(i.e. compiled with the -ffunction-sections flag), reorder the >functions to provide some code diversification to modules. > >Signed-off-by: Kristen Carlson Accardi >Reviewed-by: Kees Cook >Acked-by: Ard Biesheuvel >Tested-by: Ard Biesheuvel >Reviewed-by: Tony Luck >Tested-by: Tony Luck Hi Kristen! I've boot tested this on x86, (un)loaded some modules, and checked their resulting section addresses as a quick sanity test. Feel free to add my: Acked-by: Jessica Yu Tested-by: Jessica Yu Thank you! Jessica