From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Brent Lu <brent.lu@intel.com>
Cc: alsa-devel@alsa-project.org,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
linux-kernel@vger.kernel.org,
Daniel Stuart <daniel.stuart14@gmail.com>,
Yu-Hsuan Hsu <yuhsuan@chromium.org>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Sam McNally <sammc@chromium.org>,
Damian van Soelen <dj.vsoelen@gmail.com>
Subject: Re: [PATCH 0/2] Add period size constraint for Atom Chromebook
Date: Wed, 29 Jul 2020 14:20:49 +0300 [thread overview]
Message-ID: <20200729112049.GW3703480@smile.fi.intel.com> (raw)
In-Reply-To: <1596020585-11517-1-git-send-email-brent.lu@intel.com>
On Wed, Jul 29, 2020 at 07:03:03PM +0800, Brent Lu wrote:
> Two different constraints are implemented: one is in platform's CPU
> DAI to enforce period sizes which are already used in Android BSP. The
> other is in Atom Chromebook's machine driver to use 240 as period size.
One nit to one patch.
Overall, LGTM and thus FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Brent Lu (1):
> ASoC: intel: atom: Add period size constraint
>
> Yu-Hsuan Hsu (1):
> ASoC: Intel: Add period size constraint on strago board
>
> sound/soc/intel/atom/sst-mfld-platform-pcm.c | 15 +++++++++++++++
> sound/soc/intel/boards/cht_bsw_max98090_ti.c | 14 +++++++++++++-
> sound/soc/intel/boards/cht_bsw_rt5645.c | 14 +++++++++++++-
> 3 files changed, 41 insertions(+), 2 deletions(-)
>
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-29 11:21 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 11:03 [PATCH 0/2] Add period size constraint for Atom Chromebook Brent Lu
2020-07-29 11:03 ` [PATCH 1/2] ASoC: intel: atom: Add period size constraint Brent Lu
2020-07-29 11:19 ` Andy Shevchenko
2020-07-29 11:03 ` [PATCH 2/2] ASoC: Intel: Add period size constraint on strago board Brent Lu
2020-07-29 14:08 ` Pierre-Louis Bossart
2020-07-30 8:02 ` Lu, Brent
2020-07-30 15:27 ` Pierre-Louis Bossart
2020-07-30 15:44 ` Pierre-Louis Bossart
2020-07-30 16:17 ` Lu, Brent
2020-07-30 16:56 ` Takashi Iwai
2020-07-31 12:28 ` Lu, Brent
2020-07-29 11:20 ` Andy Shevchenko [this message]
2020-07-31 12:26 ` [PATCH v3 0/2] Add period size constraint for Atom Chromebook Brent Lu
2020-07-31 12:26 ` [PATCH v3 1/2] ASoC: intel: atom: Add period size constraint Brent Lu
2020-07-31 12:26 ` [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board Brent Lu
2020-07-31 13:34 ` Takashi Iwai
2020-08-01 8:58 ` Lu, Brent
2020-08-01 9:26 ` Takashi Iwai
2020-08-03 13:00 ` Lu, Brent
2020-08-03 15:13 ` Pierre-Louis Bossart
2020-08-03 16:45 ` Lu, Brent
2020-08-03 16:56 ` Takashi Iwai
2020-08-04 4:33 ` Lu, Brent
2020-08-04 14:24 ` Pierre-Louis Bossart
2020-08-06 16:41 ` Lu, Brent
2020-08-10 15:03 ` Pierre-Louis Bossart
2020-08-10 17:38 ` Yu-Hsuan Hsu
2020-08-11 2:16 ` Lu, Brent
2020-08-11 2:29 ` Yu-Hsuan Hsu
2020-08-11 7:43 ` Takashi Iwai
2020-08-11 8:25 ` Yu-Hsuan Hsu
2020-08-11 8:39 ` Takashi Iwai
2020-08-11 9:35 ` Yu-Hsuan Hsu
2020-08-11 14:53 ` Mark Brown
2020-08-11 16:54 ` Pierre-Louis Bossart
2020-08-11 17:22 ` Mark Brown
2020-08-12 3:09 ` Yu-Hsuan Hsu
2020-08-12 6:13 ` Takashi Iwai
2020-08-12 6:53 ` Yu-Hsuan Hsu
2020-08-12 6:58 ` Takashi Iwai
2020-08-12 7:43 ` Yu-Hsuan Hsu
2020-08-12 7:47 ` Takashi Iwai
2020-08-12 14:46 ` Pierre-Louis Bossart
2020-08-12 14:55 ` Takashi Iwai
2020-08-12 15:54 ` Pierre-Louis Bossart
2020-08-12 16:08 ` Lu, Brent
2020-08-12 16:38 ` Pierre-Louis Bossart
2020-08-13 6:24 ` Yu-Hsuan Hsu
2020-08-13 7:55 ` Lu, Brent
2020-08-13 8:36 ` Yu-Hsuan Hsu
2020-08-13 8:45 ` Takashi Iwai
2020-08-13 12:57 ` Pierre-Louis Bossart
2020-08-13 17:15 ` Yu-Hsuan Hsu
2020-08-21 16:40 ` [PATCH v3 0/2] Add period size constraint for Atom Chromebook Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729112049.GW3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.stuart14@gmail.com \
--cc=dj.vsoelen@gmail.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sammc@chromium.org \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yuhsuan@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).