From: Stafford Horne <shorne@gmail.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Arnd Bergmann <arnd@arndb.de>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
openrisc@lists.librecores.org
Subject: Re: [PATCH 14/24] openrisc: use asm-generic/mmu_context.h for no-op implementations
Date: Wed, 29 Jul 2020 20:45:54 +0900 [thread overview]
Message-ID: <20200729114554.GG80756@lianli.shorne-pla.net> (raw)
In-Reply-To: <20200728033405.78469-15-npiggin@gmail.com>
On Tue, Jul 28, 2020 at 01:33:55PM +1000, Nicholas Piggin wrote:
> Cc: Jonas Bonn <jonas@southpole.se>
> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Cc: Stafford Horne <shorne@gmail.com>
> Cc: openrisc@lists.librecores.org
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> arch/openrisc/include/asm/mmu_context.h | 8 +++-----
> arch/openrisc/mm/tlb.c | 2 ++
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/mmu_context.h b/arch/openrisc/include/asm/mmu_context.h
> index ced577542e29..a6702384c77d 100644
> --- a/arch/openrisc/include/asm/mmu_context.h
> +++ b/arch/openrisc/include/asm/mmu_context.h
> @@ -17,13 +17,13 @@
>
> #include <asm-generic/mm_hooks.h>
>
> +#define init_new_context init_new_context
> extern int init_new_context(struct task_struct *tsk, struct mm_struct *mm);
> +#define destroy_context destroy_context
> extern void destroy_context(struct mm_struct *mm);
> extern void switch_mm(struct mm_struct *prev, struct mm_struct *next,
> struct task_struct *tsk);
>
> -#define deactivate_mm(tsk, mm) do { } while (0)
> -
> #define activate_mm(prev, next) switch_mm((prev), (next), NULL)
>
> /* current active pgd - this is similar to other processors pgd
> @@ -32,8 +32,6 @@ extern void switch_mm(struct mm_struct *prev, struct mm_struct *next,
>
> extern volatile pgd_t *current_pgd[]; /* defined in arch/openrisc/mm/fault.c */
>
> -static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
> -{
> -}
> +#include <asm-generic/mmu_context.h>
This looks ok.
> #endif
> diff --git a/arch/openrisc/mm/tlb.c b/arch/openrisc/mm/tlb.c
> index 4b680aed8f5f..821aab4cf3be 100644
> --- a/arch/openrisc/mm/tlb.c
> +++ b/arch/openrisc/mm/tlb.c
> @@ -159,6 +159,7 @@ void switch_mm(struct mm_struct *prev, struct mm_struct *next,
> * instance.
> */
>
> +#define init_new_context init_new_context
> int init_new_context(struct task_struct *tsk, struct mm_struct *mm)
> {
> mm->context = NO_CONTEXT;
> @@ -170,6 +171,7 @@ int init_new_context(struct task_struct *tsk, struct mm_struct *mm)
> * drops it.
> */
>
> +#define destroy_context destroy_context
> void destroy_context(struct mm_struct *mm)
> {
> flush_tlb_mm(mm);
I don't think we need the #define's in the .c file. Do we?
-Stafford
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-07-29 11:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 3:33 [PATCH 00/24] Use asm-generic for mmu_context no-op functions Nicholas Piggin
2020-07-28 3:33 ` [PATCH 01/24] asm-generic: add generic versions of mmu context functions Nicholas Piggin
2020-07-28 4:01 ` Vineet Gupta
2020-07-28 10:37 ` Nicholas Piggin
2020-08-26 13:59 ` Nicholas Piggin
2020-07-28 5:53 ` kernel test robot
2020-07-28 23:52 ` kernel test robot
2020-07-28 3:33 ` [PATCH 02/24] alpha: use asm-generic/mmu_context.h for no-op implementations Nicholas Piggin
2020-07-28 3:33 ` [PATCH 03/24] arc: " Nicholas Piggin
2020-07-28 3:58 ` Vineet Gupta
2020-07-28 3:33 ` [PATCH 04/24] arm: " Nicholas Piggin
2020-07-28 4:14 ` Vineet Gupta
2020-08-26 14:14 ` Nicholas Piggin
2020-07-28 3:33 ` [PATCH 05/24] arm64: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 06/24] csky: " Nicholas Piggin
2020-07-28 4:09 ` Guo Ren
2020-07-28 3:33 ` [PATCH 07/24] hexagon: " Nicholas Piggin
2020-08-11 18:34 ` Brian Cain
2020-07-28 3:33 ` [PATCH 08/24] ia64: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 09/24] m68k: " Nicholas Piggin
2020-07-30 8:11 ` kernel test robot
2020-07-28 3:33 ` [PATCH 10/24] microblaze: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 11/24] mips: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 12/24] nds32: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 13/24] nios2: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 14/24] openrisc: " Nicholas Piggin
2020-07-29 11:45 ` Stafford Horne [this message]
2020-08-26 14:33 ` Nicholas Piggin
2020-07-28 3:33 ` [PATCH 15/24] parisc: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 16/24] powerpc: " Nicholas Piggin
2020-07-28 3:33 ` [PATCH 17/24] riscv: " Nicholas Piggin
2020-07-30 21:20 ` Palmer Dabbelt
2020-07-28 3:33 ` [PATCH 18/24] s390: " Nicholas Piggin
2020-07-28 3:34 ` [PATCH 19/24] sh: " Nicholas Piggin
2020-07-28 3:34 ` [PATCH 20/24] sparc: " Nicholas Piggin
2020-07-28 3:34 ` [PATCH 21/24] um: " Nicholas Piggin
2020-07-28 3:34 ` [PATCH 22/24] unicore32: " Nicholas Piggin
2020-07-28 3:34 ` [PATCH 23/24] x86: " Nicholas Piggin
2020-07-28 10:54 ` peterz
2020-07-28 3:34 ` [PATCH 24/24] xtensa: " Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729114554.GG80756@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=arnd@arndb.de \
--cc=jonas@southpole.se \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=openrisc@lists.librecores.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).