From: Jessica Yu <jeyu@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] modules: return licensing information from find_symbol
Date: Wed, 29 Jul 2020 18:48:00 +0200 [thread overview]
Message-ID: <20200729164759.GA17594@linux-8ccs> (raw)
In-Reply-To: <20200729062711.13016-7-hch@lst.de>
+++ Christoph Hellwig [29/07/20 08:27 +0200]:
>Report the GPLONLY status through a new argument.
>
>Signed-off-by: Christoph Hellwig <hch@lst.de>
>---
> include/linux/module.h | 2 +-
> kernel/module.c | 16 +++++++++++-----
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
>diff --git a/include/linux/module.h b/include/linux/module.h
>index b79219eed83c56..c9bc3412ae4465 100644
>--- a/include/linux/module.h
>+++ b/include/linux/module.h
>@@ -582,7 +582,7 @@ struct module *find_module(const char *name);
> struct symsearch {
> const struct kernel_symbol *start, *stop;
> const s32 *crcs;
>- enum {
>+ enum mod_licence {
> NOT_GPL_ONLY,
> GPL_ONLY,
> WILL_BE_GPL_ONLY,
>diff --git a/kernel/module.c b/kernel/module.c
>index 54e853c7212f72..a907bc57d343f9 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -495,6 +495,7 @@ struct find_symbol_arg {
> struct module *owner;
> const s32 *crc;
> const struct kernel_symbol *sym;
>+ enum mod_licence licence;
Just a small nit. Most of module.c uses license rather than licence -
could we unify the spelling to remain consistent? Sigh, American vs.
British English.. :)
next prev parent reply other threads:[~2020-07-29 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 6:27 inherit TAINT_PROPRIETARY_MODULE Christoph Hellwig
2020-07-29 6:27 ` [PATCH 1/7] modules: mark ref_module static Christoph Hellwig
2020-07-29 6:27 ` [PATCH 2/7] modules: mark find_symbol static Christoph Hellwig
2020-07-29 16:13 ` Jessica Yu
2020-07-29 16:24 ` Greg Kroah-Hartman
2020-07-29 17:06 ` Christoph Hellwig
2020-07-29 17:25 ` Joe Lawrence
2020-07-29 6:27 ` [PATCH 3/7] modules: mark each_symbol_section static Christoph Hellwig
2020-07-29 6:27 ` [PATCH 4/7] modules: unexport __module_text_address Christoph Hellwig
2020-07-29 6:27 ` [PATCH 5/7] modules: unexport __module_address Christoph Hellwig
2020-07-29 6:27 ` [PATCH 6/7] modules: return licensing information from find_symbol Christoph Hellwig
2020-07-29 16:48 ` Jessica Yu [this message]
2020-07-29 17:06 ` Christoph Hellwig
2020-07-29 6:27 ` [PATCH 7/7] modules: inherit TAINT_PROPRIETARY_MODULE Christoph Hellwig
2020-07-29 6:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729164759.GA17594@linux-8ccs \
--to=jeyu@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).