From: Fenghua Yu <fenghua.yu@intel.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Shanbhogue, Vedvyas" <vedvyas.shanbhogue@intel.com>,
"Luck, Tony" <tony.luck@intel.com>, H Peter Anvin <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>, x86 <x86@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] x86/bus_lock: Enable bus lock detection
Date: Wed, 29 Jul 2020 22:07:14 +0000 [thread overview]
Message-ID: <20200729220714.GA318659@otcwcpicx6.sc.intel.com> (raw)
In-Reply-To: <20200729203905.GN27751@linux.intel.com>
Hi, Sean,
On Wed, Jul 29, 2020 at 01:39:05PM -0700, Sean Christopherson wrote:
> On Wed, Jul 29, 2020 at 08:35:57PM +0000, Fenghua Yu wrote:
> > If sld=fatal and bld=ratelimit (both sld and bld are enabled in hw),
> > a split lock always generates #AC and kills the app and bld will never have
> > a chance to trigger #DB for split lock. So effectively the combination makes
> > the kernel to take two different actions after detecting a bus lock: if the
> > bus lock comes from a split lock, fatal (sld); if the bus lock comes from
> > lock to non-WB memory, ratelimit (bld). Seems this is not a useful combination
> > and is not what the user really wants to do because the user wants ratelimit
> > for BLD, right?
>
> I understood all off that. And as I user I want to run sld=fatal and
> bld=ratelimit to provide maximum protection, i.e. disallow split locks at
> all times, and ratelimit the crud SLD #AC can't catch.
Then this will expand the current usages and do need two options. Let me work
on adding a new "bus_lock_detect=" option as you suggested.
Thanks.
-Fenghua
next prev parent reply other threads:[~2020-07-29 22:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 21:35 [PATCH RFC] x86/bus_lock: Enable bus lock detection Fenghua Yu
2020-07-29 3:02 ` Sean Christopherson
2020-07-29 8:50 ` peterz
2020-07-29 18:09 ` Yu, Fenghua
2020-07-29 18:46 ` Sean Christopherson
2020-07-29 19:42 ` Fenghua Yu
2020-07-29 20:00 ` Sean Christopherson
2020-07-29 20:09 ` peterz
2020-07-29 20:35 ` Fenghua Yu
2020-07-29 20:39 ` Sean Christopherson
2020-07-29 22:07 ` Fenghua Yu [this message]
2020-07-29 23:28 ` Sean Christopherson
2020-07-29 8:49 ` peterz
2020-07-29 20:40 ` Fenghua Yu
2020-07-29 21:09 ` peterz
2020-07-30 10:08 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729220714.GA318659@otcwcpicx6.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vedvyas.shanbhogue@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).