From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E48AEC433E1 for ; Thu, 30 Jul 2020 06:25:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCBDD2075F for ; Thu, 30 Jul 2020 06:25:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728766AbgG3GZ2 (ORCPT ); Thu, 30 Jul 2020 02:25:28 -0400 Received: from verein.lst.de ([213.95.11.211]:54692 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728548AbgG3GZ2 (ORCPT ); Thu, 30 Jul 2020 02:25:28 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 19D0968AFE; Thu, 30 Jul 2020 08:25:25 +0200 (CEST) Date: Thu, 30 Jul 2020 08:25:24 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Linus Torvalds , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: add file system helpers that take kernel pointers for the init code v4 Message-ID: <20200730062524.GA17980@lst.de> References: <20200728163416.556521-1-hch@lst.de> <20200729195117.GE951209@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729195117.GE951209@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 08:51:17PM +0100, Al Viro wrote: > On Tue, Jul 28, 2020 at 06:33:53PM +0200, Christoph Hellwig wrote: > > Hi Al and Linus, > > > > currently a lot of the file system calls in the early in code (and the > > devtmpfs kthread) rely on the implicit set_fs(KERNEL_DS) during boot. > > This is one of the few last remaining places we need to deal with to kill > > off set_fs entirely, so this series adds new helpers that take kernel > > pointers. These helpers are in init/ and marked __init and thus will > > be discarded after bootup. A few also need to be duplicated in devtmpfs, > > though unfortunately. > > > > The series sits on top of my previous > > > > "decruft the early init / initrd / initramfs code v2" > > Could you fold the fixes in the parent branch to avoid the bisect hazards? > As it is, you have e.g. "initd: pass a non-f_pos offset to kernel_read/kernel_write" > that ought to go into "initrd: switch initrd loading to struct file based APIs"... I'm not a huge fan of rebasing after it has been out for a long time and with pending other patches on top of it. But at your request I've now folded the fixes and force pushed it.