From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7E1C433E0 for ; Thu, 30 Jul 2020 23:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1CB52083B for ; Thu, 30 Jul 2020 23:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596150665; bh=d7EuQ0AAcl/JAtg15EpS6qwrrRhGuijEjeshu+bi+fQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=e7V/FIL4z9KzFCmQ1WBoxcaPDiOXBG0haVDuseieiB92VXWSjqg/p7UqEsXw+Wllg SyZPN9l8ktFMTVS05UGf31tSEBdnLBHUUBc+Pk8iKs5YsH7/ahlo2jaxKUFpvBKuzJ Ib8YK72zwjttkl6XHCRKPJrcgneeUAhDrN+TyGE0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730678AbgG3XLE (ORCPT ); Thu, 30 Jul 2020 19:11:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:53170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728588AbgG3XLD (ORCPT ); Thu, 30 Jul 2020 19:11:03 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAE4020809; Thu, 30 Jul 2020 23:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596150663; bh=d7EuQ0AAcl/JAtg15EpS6qwrrRhGuijEjeshu+bi+fQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yKMAJx19arwhG8RMKjMSXZm20W5syYg2r9Vfi5N5havOQGeHUQ0zxA6h+j/rEJYdH xZH2sLoG8q8tRRYG6pQ8qa/bDOapthREjYdv+uodN7gaLgpudBs065yAV/57MLiQda E/YRl27bjYeYXfOi/qIT8O7fVCLPYDJnyoTBT+0I= Date: Thu, 30 Jul 2020 16:11:01 -0700 From: Jakub Kicinski To: Moshe Shemesh Cc: Jacob Keller , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jiri Pirko , Vasundhara Volam Subject: Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command Message-ID: <20200730161101.48f42c5b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <3352bd96-d10e-6961-079d-5c913a967513@mellanox.com> References: <1595847753-2234-1-git-send-email-moshe@mellanox.com> <1595847753-2234-2-git-send-email-moshe@mellanox.com> <20200727175802.04890dd3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200728135808.GC2207@nanopsycho> <464add44-3ab1-21b8-3dba-a88202350bb9@intel.com> <20200728114458.762b5396@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200728130653.7ce2f013@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <04f00024-758c-bc19-c187-49847c24a5a4@mellanox.com> <20200729140708.5f914c15@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <3352bd96-d10e-6961-079d-5c913a967513@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jul 2020 15:30:45 +0300 Moshe Shemesh wrote: > >>> My expectations would be that the driver must perform the lowest > >>> reset level possible that satisfies the requested functional change. > >>> IOW driver may do more, in fact it should be acceptable for the > >>> driver to always for a full HW reset (unless --live or other > >>> constraint is specified). > >> OK, but some combinations may still not be valid for specific driver > >> even if it tries lowest level possible. > > Can you give an example? > > For example take the combination of fw-live-patch and param-init. > > The fw-live-patch needs no re-initialization, while the param-init > requires driver re-initialization. > > So the only way to do that is to the one command after the other, not > really combining. You need to read my responses more carefully. I don't have fw-live-patch in my proposal. The operation is fw-activate, --live is independent and an constraint, not an operation.