From: Steven Rostedt <rostedt@goodmis.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] sched/uclamp: kill unnecessary mutex_init()
Date: Thu, 30 Jul 2020 22:57:56 -0400 [thread overview]
Message-ID: <20200730225756.11283799@oasis.local.home> (raw)
In-Reply-To: <20200725085629.98292-1-miaoqinglang@huawei.com>
On Sat, 25 Jul 2020 16:56:29 +0800
Qinglang Miao <miaoqinglang@huawei.com> wrote:
> The mutex uclamp_mutex is initialized statically. It is
> unnecessary to initialize by mutex_init().
>
Seems reasonable.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> kernel/sched/core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 29d557c1f..9a8b7ed3a 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1331,8 +1331,6 @@ static void __init init_uclamp(void)
> enum uclamp_id clamp_id;
> int cpu;
>
> - mutex_init(&uclamp_mutex);
> -
> for_each_possible_cpu(cpu)
> init_uclamp_rq(cpu_rq(cpu));
>
prev parent reply other threads:[~2020-07-31 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 8:56 [PATCH -next] sched/uclamp: kill unnecessary mutex_init() Qinglang Miao
2020-07-25 10:13 ` [tip: sched/core] sched/uclamp: Remove " tip-bot2 for Qinglang Miao
2020-07-31 2:57 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730225756.11283799@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=miaoqinglang@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).