From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=S/iQ=BK=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 674C7C433E0
	for <linux-kernel@archiver.kernel.org>; Fri, 31 Jul 2020 09:00:13 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 324692084D
	for <linux-kernel@archiver.kernel.org>; Fri, 31 Jul 2020 09:00:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732047AbgGaJAM (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 31 Jul 2020 05:00:12 -0400
Received: from verein.lst.de ([213.95.11.211]:58594 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731998AbgGaJAL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 31 Jul 2020 05:00:11 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 5382768BFE; Fri, 31 Jul 2020 11:00:09 +0200 (CEST)
Date:   Fri, 31 Jul 2020 11:00:08 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Jessica Yu <jeyu@kernel.org>
Cc:     Christoph Hellwig <hch@lst.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE
Message-ID: <20200731090008.GA12930@lst.de>
References: <20200730061027.29472-1-hch@lst.de> <20200730061027.29472-9-hch@lst.de> <20200730141232.GA31539@linux-8ccs> <20200730162957.GA22469@lst.de> <20200731085129.GA20130@linux-8ccs>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200731085129.GA20130@linux-8ccs>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote:
>> +	if (mod->using_gplonly_symbols) {
>> +		pr_info("%s: module using GPL-only symbols uses symbols from proprietary module %s.\n",
>> +			mod->name, owner->name);
>
> pr_err() maybe?
>
>> +		return false;
>> +	}
>> +
>> +	if (!test_bit(TAINT_PROPRIETARY_MODULE, &mod->taints)) {
>> +		pr_info("%s: module uses symbols from proprietary module %s, inheriting taint.\n",
>> +			mod->name, owner->name);
>
> and pr_warn()? But otherwise this looks much better.

Ok with me.  Can you just fix it up, or do you want a full resend?