From: Rob Herring <robh@kernel.org>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
ludovic.desroches@microchip.com
Subject: Re: [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller
Date: Fri, 31 Jul 2020 15:30:28 -0600 [thread overview]
Message-ID: <20200731213028.GA824739@bogus> (raw)
In-Reply-To: <20200729101922.3033616-1-codrin.ciubotariu@microchip.com>
On Wed, Jul 29, 2020 at 01:19:21PM +0300, Codrin Ciubotariu wrote:
> This patch adds DT bindings for the new Microchip S/PDIF TX Controller
> embedded inside sama7g5 SoCs.
>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
>
> Changes in v2:
> - replaced https with http
> - reworked example, included bindings;
>
> .../bindings/sound/mchp,spdiftx.yaml | 80 +++++++++++++++++++
> 1 file changed, 80 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> new file mode 100644
> index 000000000000..2b7c27391f0d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip S/PDIF Tx Controller Device Tree Bindings
> +
> +maintainers:
> + - Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> +
> +description:
> + The Microchip Sony/Philips Digital Interface Transmitter is a
> + serial port compliant with the IEC-60958 standard.
> +
> +properties:
> + "#sound-dai-cells":
> + const: 0
> +
> + compatible:
> + oneOf:
> + - const: microchip,sama7g5-spdiftx
No need for 'oneOf' when only 1 entry.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Peripheral Bus Clock
> + - description: Generic Clock
> +
> + clock-names:
> + items:
> + - const: pclk
> + - const: gclk
> +
> + dmas:
> + description: TX DMA Channel
How many? (maxItems: 1)
> +
> + dma-names:
> + const: tx
> +
> + pinctrl-0: true
> +
> + pinctrl-names:
> + const: default
You can drop pinctrl props. They are always allowed.
> +
> +required:
> + - "#sound-dai-cells"
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - dmas
> + - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/at91.h>
> + #include <dt-bindings/dma/at91.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + spdiftx@e1618000 {
> + #sound-dai-cells = <0>;
> + compatible = "microchip,sama7g5-spdiftx";
> + reg = <0xe1618000 0x4000>;
> + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&dma0 AT91_XDMAC_DT_PERID(50)>;
> + dma-names = "tx";
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 85>, <&pmc PMC_TYPE_GCK 85>;
> + clock-names = "pclk", "gclk";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spdiftx_default>;
> + };
> --
> 2.25.1
>
prev parent reply other threads:[~2020-07-31 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 10:19 [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller Codrin Ciubotariu
2020-07-29 10:19 ` [PATCH v2 2/2] ASoC: mchp-spdiftx: add driver for " Codrin Ciubotariu
2020-07-31 21:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731213028.GA824739@bogus \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codrin.ciubotariu@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).