From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56586C433DF for ; Sat, 1 Aug 2020 04:53:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 204B3206D7 for ; Sat, 1 Aug 2020 04:53:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jna6ZdIE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725821AbgHAEqY (ORCPT ); Sat, 1 Aug 2020 00:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgHAEqY (ORCPT ); Sat, 1 Aug 2020 00:46:24 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BCEAC06174A for ; Fri, 31 Jul 2020 21:46:24 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id a9so8308070pjd.3 for ; Fri, 31 Jul 2020 21:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8eAOX9UrxPIOomqROH0waMwB/lcef6OrlafyxMLp9bQ=; b=jna6ZdIEYE/Xh//wsaCdzyN+1hy0bJqKi2PGS7bu3veIPCwCg9K4In6ylF95hymXIO ThEVkE9WtswmUyazhG807PRSUs1Kqco4BQ+hC7ebO0L22dXgC1oDB2lyTZ67kJ3KGOgM VxPLRVGeVwVgVC+uwmR7pgxIMk7R+aUJ4+5Ju4U/ub2XwckOnlVotttxr/7JXpMYNT2G UqjunHEGAHIfzztqZBxupcY/NuMCg7eJ23SRZIHvBHiiUL3w4GJRDTGDHddaAiPk52+r wbIljvLxatNKipTigGkADMSxLVgd09bAhUhrrqQMiOm3xzVknU3HL/35mIFPHb+pTYg2 n1sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8eAOX9UrxPIOomqROH0waMwB/lcef6OrlafyxMLp9bQ=; b=eXY4yKmA2GvMzFZGaQbVh9S7f5m/0TQGkeY7i18g92rXUTu5gGS17Vtfmk35qu1e7I nI4nYbmsQHiBZ031Tixa4oQkLGvaRWvxaEhlKKO9nZlX/EBfrZsBNCVoB1TsMF9q2Viu x3RJD1zMemBdd58RPPEbwe/Cmn13GDBq5RNVBFJtiuH5Hsf0XjFA5s+kN8gegReBsLKw cGte9C1qMtCvxJJ7Pq0Tfp5W1WfQ1jEvIdJ3SB5wTwbrV5iViSScF8OcKyfJNhvSHWRr tc3lw0DJdCFWNw8hTfU9ySzZPOAPXMACuU+k5ilfVgQ/e2zmttpKZWUazPzecBSr4pSB wZ6A== X-Gm-Message-State: AOAM531St5n3nDqYC5jwQZIw0kKLpX+Kdq1hdu42ApAPRRxLGbpt3UTb S00+wmaQnt3ENwgLxueblRmCU+do X-Google-Smtp-Source: ABdhPJwQvwJ9GZp5qXVxaEuN0ywU8uDfDvRtej3R3yCh6DOnb5lCqsowa5jIzfUI/7b5FP0aCAIhhg== X-Received: by 2002:a17:90a:bb8a:: with SMTP id v10mr6897946pjr.144.1596257183420; Fri, 31 Jul 2020 21:46:23 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id e13sm11562563pgs.13.2020.07.31.21.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 21:46:22 -0700 (PDT) Date: Sat, 1 Aug 2020 13:46:20 +0900 From: Sergey Senozhatsky To: Andy Shevchenko Cc: Petr Mladek , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Rasmus Villemoes , Steven Rostedt Subject: Re: [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Message-ID: <20200801044620.GA683@jagdpanzerIV.localdomain> References: <20200731180825.30575-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200731180825.30575-1-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/07/31 21:08), Andy Shevchenko wrote: > First of all, there is no compile time check for the SMALL > to be ' ' (0x20, i.e. space). Second, for ZEROPAD the check > is hidden in the code. > > For better maintenance replace BUILD_BUG_ON() with static_assert() > for ZEROPAD and move it closer to the definition. While at it, > introduce check for SMALL. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Steven Rostedt (VMware) The series was applied to for-5.9 I ran more tests (+ cross compile tests: ppc/ppc64/arm/arm64/x86/x86_64). -ss