* [PATCH v3] staging: r8188eu: replace rtw_netdev_priv define with inline function
@ 2020-08-01 18:02 Ivan Safonov
0 siblings, 0 replies; only message in thread
From: Ivan Safonov @ 2020-08-01 18:02 UTC (permalink / raw)
To: Larry Finger
Cc: Greg Kroah-Hartman, B K Karthik, Michael Straube, Joe Perches,
devel, linux-kernel, Ivan Safonov
The function guarantees type checking of arguments and return value.
Result of rtw_netdev_priv macro can be assigned to pointer
with incompatible type without warning. The function allow compiler
to perform this check.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
---
Changes in v2:
- add blank line after function definition;
- improve commit message.
Changes in v3:
- use proper argument name;
- remove unnecessary parentheses.
---
drivers/staging/rtl8188eu/include/osdep_service.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h
index 31d897f1d21f..b44d602e954a 100644
--- a/drivers/staging/rtl8188eu/include/osdep_service.h
+++ b/drivers/staging/rtl8188eu/include/osdep_service.h
@@ -71,8 +71,11 @@ struct rtw_netdev_priv_indicator {
};
struct net_device *rtw_alloc_etherdev_with_old_priv(void *old_priv);
-#define rtw_netdev_priv(netdev) \
- (((struct rtw_netdev_priv_indicator *)netdev_priv(netdev))->priv)
+static inline struct adapter *rtw_netdev_priv(struct net_device *netdev)
+{
+ return ((struct rtw_netdev_priv_indicator *)netdev_priv(netdev))->priv;
+}
+
void rtw_free_netdev(struct net_device *netdev);
#define FUNC_NDEV_FMT "%s(%s)"
--
2.26.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-01 17:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-01 18:02 [PATCH v3] staging: r8188eu: replace rtw_netdev_priv define with inline function Ivan Safonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).