LKML Archive on lore.kernel.org
 help / color / Atom feed
* [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig
@ 2020-08-02  7:49 Bartosz Golaszewski
  2020-08-02 13:44 ` Andrew Lunn
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2020-08-02  7:49 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Russell King,
	David S . Miller, Jakub Kicinski
  Cc: netdev, linux-kernel, Bartosz Golaszewski, kernel test robot

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

PHYLIB is not selected by the mvusb driver but it uses mdio devres
helpers. Explicitly select MDIO_DEVRES in this driver's Kconfig entry.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1814cff26739 ("net: phy: add a Kconfig option for mdio_devres")
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/net/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index e351d65533aa..7a756e0374fd 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -190,6 +190,7 @@ config MDIO_MSCC_MIIM
 config MDIO_MVUSB
 	tristate "Marvell USB to MDIO Adapter"
 	depends on USB
+	select MDIO_DEVRES
 	help
 	  A USB to MDIO converter present on development boards for
 	  Marvell's Link Street family of Ethernet switches.
-- 
2.26.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig
  2020-08-02  7:49 [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig Bartosz Golaszewski
@ 2020-08-02 13:44 ` Andrew Lunn
  2020-08-02 20:18 ` Florian Fainelli
  2020-08-03 22:50 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-08-02 13:44 UTC (permalink / raw)
  To: Bartosz Golaszewski, g
  Cc: Florian Fainelli, Heiner Kallweit, Russell King,
	David S . Miller, Jakub Kicinski, netdev, linux-kernel,
	Bartosz Golaszewski, kernel test robot

On Sun, Aug 02, 2020 at 09:49:53AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> PHYLIB is not selected by the mvusb driver but it uses mdio devres
> helpers. Explicitly select MDIO_DEVRES in this driver's Kconfig entry.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 1814cff26739 ("net: phy: add a Kconfig option for mdio_devres")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig
  2020-08-02  7:49 [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig Bartosz Golaszewski
  2020-08-02 13:44 ` Andrew Lunn
@ 2020-08-02 20:18 ` Florian Fainelli
  2020-08-03 22:50 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-08-02 20:18 UTC (permalink / raw)
  To: Bartosz Golaszewski, Andrew Lunn, Heiner Kallweit, Russell King,
	David S . Miller, Jakub Kicinski
  Cc: netdev, linux-kernel, Bartosz Golaszewski, kernel test robot



On 8/2/2020 12:49 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> PHYLIB is not selected by the mvusb driver but it uses mdio devres
> helpers. Explicitly select MDIO_DEVRES in this driver's Kconfig entry.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 1814cff26739 ("net: phy: add a Kconfig option for mdio_devres")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig
  2020-08-02  7:49 [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig Bartosz Golaszewski
  2020-08-02 13:44 ` Andrew Lunn
  2020-08-02 20:18 ` Florian Fainelli
@ 2020-08-03 22:50 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-08-03 22:50 UTC (permalink / raw)
  To: brgl
  Cc: andrew, f.fainelli, hkallweit1, linux, kuba, netdev,
	linux-kernel, bgolaszewski, lkp

From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Sun,  2 Aug 2020 09:49:53 +0200

> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> PHYLIB is not selected by the mvusb driver but it uses mdio devres
> helpers. Explicitly select MDIO_DEVRES in this driver's Kconfig entry.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 1814cff26739 ("net: phy: add a Kconfig option for mdio_devres")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02  7:49 [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig Bartosz Golaszewski
2020-08-02 13:44 ` Andrew Lunn
2020-08-02 20:18 ` Florian Fainelli
2020-08-03 22:50 ` David Miller

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git