* [PATCH] net: ethernet: aquantia: Fix wrong return value
@ 2020-08-02 11:15 Tianjia Zhang
2020-08-03 22:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tianjia Zhang @ 2020-08-02 11:15 UTC (permalink / raw)
To: irusskikh, davem, kuba, mstarovoitov, dbezrukov, ndanilov,
tianjia.zhang, Pavel.Belous, Alexander.Loktionov,
Dmitrii.Tarakanov
Cc: netdev, linux-kernel, tianjia.zhang
In function hw_atl_a0_hw_multicast_list_set(), when an invalid
request is encountered, a negative error code should be returned.
Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions")
Cc: David VomLehn <vomlehn@texas.net>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c
index a312864969af..6640fd35b29b 100644
--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c
@@ -782,7 +782,7 @@ static int hw_atl_a0_hw_multicast_list_set(struct aq_hw_s *self,
int err = 0;
if (count > (HW_ATL_A0_MAC_MAX - HW_ATL_A0_MAC_MIN)) {
- err = EBADRQC;
+ err = -EBADRQC;
goto err_exit;
}
for (self->aq_nic_cfg->mc_list_count = 0U;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: ethernet: aquantia: Fix wrong return value
2020-08-02 11:15 [PATCH] net: ethernet: aquantia: Fix wrong return value Tianjia Zhang
@ 2020-08-03 22:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-03 22:56 UTC (permalink / raw)
To: tianjia.zhang
Cc: irusskikh, kuba, mstarovoitov, dbezrukov, ndanilov, Pavel.Belous,
Alexander.Loktionov, Dmitrii.Tarakanov, netdev, linux-kernel,
tianjia.zhang
From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Date: Sun, 2 Aug 2020 19:15:37 +0800
> In function hw_atl_a0_hw_multicast_list_set(), when an invalid
> request is encountered, a negative error code should be returned.
>
> Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions")
> Cc: David VomLehn <vomlehn@texas.net>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-03 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 11:15 [PATCH] net: ethernet: aquantia: Fix wrong return value Tianjia Zhang
2020-08-03 22:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).