From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 03/16] kconfig: qconf: remove toolBar from ConfigMainWindow members
Date: Mon, 3 Aug 2020 01:17:08 +0900 [thread overview]
Message-ID: <20200802161721.921721-3-masahiroy@kernel.org> (raw)
In-Reply-To: <20200802161721.921721-1-masahiroy@kernel.org>
This pointer is only used in the ConfigMainWindow constructor.
Drop it from the private members.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/kconfig/qconf.cc | 2 +-
scripts/kconfig/qconf.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 0ef9a1da6475..4eb846c90b1d 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1431,7 +1431,7 @@ ConfigMainWindow::ConfigMainWindow(void)
setTabOrder(configList, helpText);
configList->setFocus();
- toolBar = new QToolBar("Tools", this);
+ QToolBar *toolBar = new QToolBar("Tools", this);
addToolBar(toolBar);
backAction = new QAction(QPixmap(xpm_back), "Back", this);
diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
index 5eeab4a8bb43..b80683998635 100644
--- a/scripts/kconfig/qconf.h
+++ b/scripts/kconfig/qconf.h
@@ -326,7 +326,6 @@ public slots:
ConfigView *configView;
ConfigList *configList;
ConfigInfoView *helpText;
- QToolBar *toolBar;
QAction *backAction;
QAction *singleViewAction;
QAction *splitViewAction;
--
2.25.1
next prev parent reply other threads:[~2020-08-02 16:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 16:17 [PATCH 01/16] kconfig: qconf: rename 'config' to 'fileMenu' Masahiro Yamada
2020-08-02 16:17 ` [PATCH 02/16] kconfig: qconf: remove 'menu' variable Masahiro Yamada
2020-08-02 16:17 ` Masahiro Yamada [this message]
2020-08-02 16:17 ` [PATCH 04/16] kconfig: qconf: overload addToolBar() to create and insert toolbar Masahiro Yamada
2020-08-02 16:17 ` [PATCH 05/16] kconfig: qconf: remove unused ConfigList::listView() Masahiro Yamada
2020-08-02 16:17 ` [PATCH 06/16] kconfig: qconf: remove name from ConfigSearchWindow constructor Masahiro Yamada
2020-08-02 16:17 ` [PATCH 07/16] kconfig: qconf: omit parent to QHBoxLayout() Masahiro Yamada
2020-08-02 16:17 ` [PATCH 08/16] kconfig: qconf: remove unused argument from ConfigList::updateList() Masahiro Yamada
2020-08-02 16:17 ` [PATCH 09/16] kconfig: qconf: remove unused argument from ConfigView::updateList() Masahiro Yamada
2020-08-02 16:17 ` [PATCH 10/16] kconfig: qconf: remove 'parent' from ConfigList::updateMenuList() Masahiro Yamada
2020-08-02 16:17 ` [PATCH 11/16] kconfig: qconf: drop more localization code Masahiro Yamada
2020-08-02 16:17 ` [PATCH 12/16] kconfig: qconf: remove ConfigItem::pixmap/setPixmap Masahiro Yamada
2020-08-02 16:17 ` [PATCH 13/16] kconfig: qconf: remove ConfigList::addColumn/removeColumn Masahiro Yamada
2020-08-02 16:17 ` [PATCH 14/16] kconfig: qconf: remove ConfigItem::text/setText Masahiro Yamada
2020-08-02 16:17 ` [PATCH 15/16] kconfig: qconf: remove unused voidPix, menuInvPix Masahiro Yamada
2020-08-02 16:17 ` [PATCH 16/16] kconfig: qconf: refactor icon setups Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200802161721.921721-3-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).