From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB31C433DF for ; Sun, 2 Aug 2020 17:20:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A156E205CB for ; Sun, 2 Aug 2020 17:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbgHBRUj (ORCPT ); Sun, 2 Aug 2020 13:20:39 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:39300 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbgHBRUj (ORCPT ); Sun, 2 Aug 2020 13:20:39 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 072HKJqe027023; Sun, 2 Aug 2020 19:20:19 +0200 Date: Sun, 2 Aug 2020 19:20:19 +0200 From: Willy Tarreau To: Stephen Rothwell Cc: Michael Ellerman , Linux-kernel Mailing List , PowerPC , Linus Torvalds Subject: Re: powerpc: build failures in Linus' tree Message-ID: <20200802172019.GB26677@1wt.eu> References: <20200802204842.36bca162@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200802204842.36bca162@canb.auug.org.au> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 02, 2020 at 08:48:42PM +1000, Stephen Rothwell wrote: > Hi all, > > We are getting build failures in some PowerPC configs for Linus' tree. > See e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/14306515/ > > In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:18, > from /kisskb/src/arch/powerpc/include/asm/percpu.h:13, > from /kisskb/src/include/linux/random.h:14, > from /kisskb/src/include/linux/net.h:18, > from /kisskb/src/net/ipv6/ip6_fib.c:20: > /kisskb/src/arch/powerpc/include/asm/mmu.h:139:22: error: unknown type name 'next_tlbcam_idx' > 139 | DECLARE_PER_CPU(int, next_tlbcam_idx); > > I assume this is caused by commit > > 1c9df907da83 ("random: fix circular include dependency on arm64 after addition of percpu.h") > > But I can't see how, sorry. So there, asm/mmu.h includes asm/percpu.h, which includes asm/paca.h, which includes asm/mmu.h. I suspect that we can remove asm/paca.h from asm/percpu.h as it *seems* to be only used by the #define __my_cpu_offset but I don't know if anything will break further, especially if this __my_cpu_offset is used anywhere without this paca definition. Willy