From: David Miller <davem@davemloft.net>
To: tianjia.zhang@linux.alibaba.com
Cc: claudiu.manoil@nxp.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, tianjia.zhang@alibaba.com
Subject: Re: [PATCH] net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower()
Date: Mon, 03 Aug 2020 15:58:02 -0700 (PDT) [thread overview]
Message-ID: <20200803.155802.2215012000142493904.davem@davemloft.net> (raw)
In-Reply-To: <20200802111538.5338-1-tianjia.zhang@linux.alibaba.com>
From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Date: Sun, 2 Aug 2020 19:15:38 +0800
> In the case of invalid rule, a positive value EINVAL is returned here.
> I think this is a typo error. It is necessary to return an error value.
>
> Cc: Po Liu <Po.Liu@nxp.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Applied.
prev parent reply other threads:[~2020-08-03 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 11:15 [PATCH] net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower() Tianjia Zhang
2020-08-03 22:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803.155802.2215012000142493904.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tianjia.zhang@alibaba.com \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).