linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Pavel Machek <pavel@denx.de>, Qiwu Huang <yanziily@gmail.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	jiangfei1@xiaomi.com, Qiwu Huang <huangqiwu@xiaomi.com>
Subject: Re: [PATCH v4 1/4] power: supply: core: add quick charge type property
Date: Mon, 3 Aug 2020 13:56:44 +0200	[thread overview]
Message-ID: <20200803115644.GC955269@kroah.com> (raw)
In-Reply-To: <20200803114950.oyb3gzyiccybah3u@earth.universe>

On Mon, Aug 03, 2020 at 01:49:50PM +0200, Sebastian Reichel wrote:
> More importantely I prefer not to merge new APIs without any users
> (i.e. a driver making use of those values). Having a reference
> driver means, that there is an example how to use the values
> correctly and proves it is actually needed upstream. Right now
> this looks like "let's modify the upstream kernel, so that we can
> easily maintain our out of tree driver".

Agreed.  Qiwu, can you also submit your driver so we can see these
values be used?

thanks,

greg k-h

  reply	other threads:[~2020-08-03 11:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20  5:47 [PATCH v4 0/4] add some power supply properties about wireless/wired charging Qiwu Huang
2020-07-20  5:47 ` [PATCH v4 1/4] power: supply: core: add quick charge type property Qiwu Huang
2020-08-02 12:00   ` Pavel Machek
2020-08-02 12:37     ` Greg KH
2020-08-02 14:28       ` Pavel Machek
2020-08-02 16:57         ` Greg KH
2020-08-03 11:49           ` Sebastian Reichel
2020-08-03 11:56             ` Greg KH [this message]
2020-08-04  2:11               ` ivan
2020-08-04  7:49                 ` Greg KH
2020-07-20  5:47 ` [PATCH v4 2/4] power: supply: core: add wireless charger adapter " Qiwu Huang
2020-07-20  5:47 ` [PATCH v4 3/4] power: supply: core: add wireless signal strength property Qiwu Huang
2020-07-20  5:47 ` [PATCH v4 4/4] power: supply: core: property to control reverse charge Qiwu Huang
2020-07-20  8:21 ` [PATCH v4 0/4] add some power supply properties about wireless/wired charging Greg KH
2020-07-21  3:12   ` ivan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803115644.GC955269@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=huangqiwu@xiaomi.com \
    --cc=jiangfei1@xiaomi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@denx.de \
    --cc=sre@kernel.org \
    --cc=yanziily@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).