From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: ioana.ciornei@nxp.com, ruxandra.radulescu@nxp.com,
kuba@kernel.org, andrew@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dpaa2-eth: Fix passing zero to 'PTR_ERR' warning
Date: Tue, 04 Aug 2020 16:11:08 -0700 (PDT) [thread overview]
Message-ID: <20200804.161108.958554880119569573.davem@davemloft.net> (raw)
In-Reply-To: <20200804132643.42104-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 4 Aug 2020 21:26:43 +0800
> Fix smatch warning:
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2419
> alloc_channel() warn: passing zero to 'ERR_PTR'
>
> setup_dpcon() should return ERR_PTR(err) instead of zero in error
> handling case.
>
> Fixes: d7f5a9d89a55 ("dpaa2-eth: defer probe on object allocate")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2020-08-04 23:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 13:26 [PATCH] dpaa2-eth: Fix passing zero to 'PTR_ERR' warning YueHaibing
2020-08-04 23:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804.161108.958554880119569573.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).