From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: agross@kernel.org, kishon@ti.com, vkoul@kernel.org,
dovl@codeaurora.org, ygardi@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
tianjia.zhang@alibaba.com
Subject: Re: [PATCH] phy: qcom-ufs: Fix wrong return value in ufs_qcom_phy_calibrate()
Date: Mon, 3 Aug 2020 23:05:05 -0700 [thread overview]
Message-ID: <20200804060505.GJ61202@yoga> (raw)
In-Reply-To: <20200802111546.5611-1-tianjia.zhang@linux.alibaba.com>
On Sun 02 Aug 04:15 PDT 2020, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: adaafaa393ef1 ("phy: qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers")
> Cc: Yaniv Gardi <ygardi@codeaurora.org>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Thanks for your patch Tianjia.
The support provided by this driver was added to phy-qcom-qmp.c a while
back and in what's will become 5.9 the phy-qcom-ufs.c driver is removed.
So your change is unfortunately no longer needed.
Regards,
Bjorn
> ---
> drivers/phy/qualcomm/phy-qcom-ufs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index 763c8d396af1..49d47dc5bfd4 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -24,7 +24,7 @@ int ufs_qcom_phy_calibrate(struct ufs_qcom_phy *ufs_qcom_phy,
>
> if (!tbl_A) {
> dev_err(ufs_qcom_phy->dev, "%s: tbl_A is NULL", __func__);
> - ret = EINVAL;
> + ret = -EINVAL;
> goto out;
> }
>
> @@ -42,7 +42,7 @@ int ufs_qcom_phy_calibrate(struct ufs_qcom_phy *ufs_qcom_phy,
> if (!tbl_B) {
> dev_err(ufs_qcom_phy->dev, "%s: tbl_B is NULL",
> __func__);
> - ret = EINVAL;
> + ret = -EINVAL;
> goto out;
> }
>
> --
> 2.26.2
>
prev parent reply other threads:[~2020-08-04 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 11:15 [PATCH] phy: qcom-ufs: Fix wrong return value in ufs_qcom_phy_calibrate() Tianjia Zhang
2020-08-04 6:05 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804060505.GJ61202@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dovl@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@alibaba.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=vkoul@kernel.org \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).