From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D01C433E0 for ; Tue, 4 Aug 2020 11:58:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 843FA208A9 for ; Tue, 4 Aug 2020 11:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596542334; bh=Ws9mTM9hLH76bfhcMTDlEjXSJGOZ+kmUZwL41/jkJvs=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=iQ9cIzKqzp4cyS1eequl2pp8xmn3NUp2Ihr3Sl7fBDN+ahFIB/VJaFZzMj7ZOurs6 lbVh0lT9UzdYhCamDY0fa/vdH/s+pj2Hd3KMrPUey+ZKYGRKccSV6NL+zLMbWjxcX2 NK13xeVpE3PnOGdLOBBDNi8Y3WZiTRoCgOUdEW3w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730456AbgHDL6w (ORCPT ); Tue, 4 Aug 2020 07:58:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:40458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730356AbgHDL6i (ORCPT ); Tue, 4 Aug 2020 07:58:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57DD82086A; Tue, 4 Aug 2020 11:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596542316; bh=Ws9mTM9hLH76bfhcMTDlEjXSJGOZ+kmUZwL41/jkJvs=; h=Date:From:To:Subject:References:In-Reply-To:From; b=CIaDeLzet63ckJ2uON4/mDPUc7KGHW3WSk0gncq4u7vyzIJFuXgdOPeGJ6yI6QjEG +9aYTIGzE+oZgnnyjaQnfOL0FYDAOkOaoI34zUJ9Q2CnvQhQQKy64F8lXa3jr4c5aQ SM3w3WsDEieWhTkXewHYOTkyYcnMI+uc6FE9s4Ro= Date: Tue, 4 Aug 2020 13:58:17 +0200 From: Greg KH To: Samuel Thibault , linux-kernel@vger.kernel.org, speakup@linux-speakup.org Subject: Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled Message-ID: <20200804115817.GC203147@kroah.com> References: <20200804111332.dex7jobmabifdzw5@function> <20200804113413.GA181242@kroah.com> <20200804114951.ijs3hnezi4f64nll@function> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200804114951.ijs3hnezi4f64nll@function> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2020 at 01:49:51PM +0200, Samuel Thibault wrote: > Greg KH, le mar. 04 août 2020 13:34:13 +0200, a ecrit: > > On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote: > > > Drivers using serialio are already made available in Kconfig only under > > > the ISA condition. > > > > > > This solves warnings in inb/outb macros on platform that do not have > > > support for ISA. > > > > > > Signed-off-by: Samuel Thibault > > > > > > Index: linux-2.6/drivers/accessibility/speakup/Makefile > > > =================================================================== > > > --- linux-2.6.orig/drivers/accessibility/speakup/Makefile > > > +++ linux-2.6/drivers/accessibility/speakup/Makefile > > > @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe > > > obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o > > > > > > obj-$(CONFIG_SPEAKUP) += speakup.o > > > +obj-$(CONFIG_ISA) += serialio.o > > > speakup-y := \ > > > buffers.o \ > > > devsynth.o \ > > > @@ -25,7 +26,6 @@ speakup-y := \ > > > keyhelp.o \ > > > kobjects.o \ > > > selection.o \ > > > - serialio.o \ > > > spk_ttyio.o \ > > > synth.o \ > > > thread.o \ > > > > Oops, no, I get the following build errors with this patch: > > > > ERROR: modpost: "spk_wait_for_xmitr" [drivers/accessibility/speakup/speakup.ko] undefined! > > Yes, it depends on the first of the queue. Nope, different errors with both patches applied: ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_keypc.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_keypc.ko] undefined! ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_dtlk.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_dtlk.ko] undefined! ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_decpc.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_decpc.ko] undefined! ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_acntpc.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_acntpc.ko] undefined :(