From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Jin, Yao" <yao.jin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com,
irogers@google.com
Subject: Re: [PATCH v2] perf evsel: Don't set sample_regs_intr/sample_regs_user for dummy event
Date: Tue, 4 Aug 2020 09:06:16 -0300 [thread overview]
Message-ID: <20200804120616.GD3440834@kernel.org> (raw)
In-Reply-To: <32664190-9a2b-6ce6-3cbc-87b46c85d21e@intel.com>
Em Tue, Aug 04, 2020 at 10:06:56AM +0300, Adrian Hunter escreveu:
> On 29/07/20 10:23 am, Jin, Yao wrote:
> > Hi Adrian,
> >
> > Could you help to check if following condition will break PT?
> >
> > "(opts->sample_intr_regs && !evsel->no_aux_samples &&
> > !evsel__is_dummy_event(evsel))"
>
> Sorry for slow response - I've been away.
>
> This is fine. It will not break PT.
>
> no_aux_samples is useful for evsels that have been added by the code rather
> than requested by the user. For old kernels PT adds sched_switch tracepoint
> to track context switches (before the current context switch event was
> added) and having auxiliary sample information unnecessarily uses up space
> in the perf buffer.
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks for checking and providing the comment, that I added as a
committer note together with your Acked-by, appreciated.
- Arnaldo
prev parent reply other threads:[~2020-08-04 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 1:00 [PATCH v2] perf evsel: Don't set sample_regs_intr/sample_regs_user for dummy event Jin Yao
2020-07-20 9:17 ` Jiri Olsa
2020-07-22 5:00 ` Jin, Yao
2020-07-22 11:08 ` Jiri Olsa
2020-07-23 1:01 ` Jin, Yao
2020-07-29 7:23 ` Jin, Yao
2020-08-04 7:06 ` Adrian Hunter
2020-08-04 12:06 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804120616.GD3440834@kernel.org \
--to=acme@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).