linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Ilia Lin <ilia.lin@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	ilial@codeaurora.org, kuba@kernel.org, jiri@mellanox.com,
	edumazet@google.com, ap420073@gmail.com,
	xiyou.wangcong@gmail.com, maximmi@mellanox.com,
	Ilia Lin <ilia.lin@kernel.org>,
	netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: dev: Add API to check net_dev readiness
Date: Tue, 4 Aug 2020 21:24:35 +0200	[thread overview]
Message-ID: <20200804192435.GG1919070@lunn.ch> (raw)
In-Reply-To: <CA+5LGR1KwePssqhCkZ6qT_W87fO2o1XPze53mJwjkTWtphiWrA@mail.gmail.com>

On Tue, Aug 04, 2020 at 08:47:18PM +0300, Ilia Lin wrote:
> Hi Andrew and David,

Hi Ilia

Please don't top post.

> 
> Thank you for your comments!
> 
> The client driver is still work in progress, but it can be seen here:
> https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platform/msm/ipa/ipa_api.c#n3842
> 
> For HW performance reasons, it has to be in subsys_initcall.

Well, until the user of this new API is ready, we will not accept the
patch.

You also need to explain "For HW performance reasons". Why is this
driver special that it can do things which no over driver does?

And you should really be working on net-next, not this dead kernel
version, if you want to get merged into mainline.

Network drivers do not belong is drivers/platform. There is also ready
a drivers/net/ipa, so i assume you will move there.

  Andrew

  reply	other threads:[~2020-08-04 19:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26 19:37 [PATCH] net: dev: Add API to check net_dev readiness Ilia Lin
2020-07-26 19:45 ` Andrew Lunn
2020-07-27 17:32   ` David Miller
2020-08-04 17:47     ` Ilia Lin
2020-08-04 19:24       ` Andrew Lunn [this message]
2020-08-05 10:31         ` Ilia Lin
2020-08-05 13:14           ` Andrew Lunn
2020-08-04 18:42     ` Ilia Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804192435.GG1919070@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ilia.lin@gmail.com \
    --cc=ilia.lin@kernel.org \
    --cc=ilial@codeaurora.org \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximmi@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).